Skip to content
This repository was archived by the owner on Nov 3, 2023. It is now read-only.

Cherrypick a few fixes #7

Merged
graceguo-supercat merged 3 commits into from
Feb 5, 2018
Merged

Cherrypick a few fixes #7

graceguo-supercat merged 3 commits into from
Feb 5, 2018

Conversation

@graceguo-supercat
Copy link
Collaborator

@graceguo-supercat graceguo-supercat commented Feb 5, 2018 •
edited
Loading

mistercrunch and others added 3 commits February 5, 2018 10:53
@mistercrunch
[explore] fix missing CacheLabel (apache#4326)
4a135c5 
Also adding a basic unit test.

(cherry picked from commit 1f8fccc)
@timifasubaa
Refactor import csv (apache#4298)
ff2bff9 
* move helpers to utils

* make form use queryselector

* refactor exception throwing and handling

* update db_connection access point

* nits

(cherry picked from commit 6d37d97)
1. fix check filters change logic (apache#4339)
d2bb6cd 
2. should show chart after loading completed

(cherry picked from commit e965f95)
@michellethomas
Copy link

michellethomas commented Feb 5, 2018

lgtm

@timifasubaa
Copy link

timifasubaa commented Feb 5, 2018

LGTM

@graceguo-supercat graceguo-supercat merged commit 601fe7c into airbnb:airbnb-master Feb 5, 2018
@graceguo-supercat graceguo-supercat deleted the gg-CherryPickFixJSError branch March 7, 2018 19:18
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
@williaster @zhaoyongjie
[core] support empty CSRF token (#7)
f5d62e3 
* [core][deps] remove unused deps

* [core][test] add test for response.ok=false

* [core] support csrf_token=''

* [core][tests] move mock to sole function that uses it
michellethomas pushed a commit that referenced this pull request Dec 1, 2021
@betodealmeida @zhaoyongjie
fix(legacy-preset-chart-nvd3): redraw bar values after legend change (#7
444bb03 
)

* fix(legacy-preset-chart-nvd3): redraw bar values after legend change

* fix(legacy-preset-chart-nvd3): avoid creating multiple nodes

* fix(legacy-preset-chart-nvd3): improve remove
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@michellethomas michellethomas michellethomas approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@graceguo-supercat @michellethomas @timifasubaa @mistercrunch