fix(sqllab): invalid height in ResultTable

[justinpark]

SUMMARY

During the process of fixing a bug in #36540, unnecessary logic for calculating the ResultSet table height was added. As a result, the table height does not match the actual content height, making it impossible to view the content at the bottom of the table. In the case of ResultTable, the height is automatically adjusted using AutoSizer, so if you provide the height via CSS, the table will be rendered correctly according to the desired height.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

locally tested

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #21c0de

Actionable Suggestions - 0

Additional Suggestions - 1

• superset-frontend/src/SqlLab/components/QueryTable/styles.ts - 1

  • UI height constraint may reduce usability · Line 48-48
    The added height: 500px may limit the table height on large screens where 50vh exceeds 500px, potentially making the result set less usable. Consider using min-height instead to set a minimum without capping expansion.
    Code suggestion

     @@ -48,1 +48,1 @@
    -  height: 500px;
    +  min-height: 500px;

Review Details

• Files reviewed - 3 · Commit Range: 521d1f6..521d1f6

  • superset-frontend/src/SqlLab/components/QueryTable/index.tsx
  • superset-frontend/src/SqlLab/components/QueryTable/styles.ts
  • superset-frontend/src/SqlLab/components/ResultSet/index.tsx
• Files skipped - 0
• Tools

  • Eslint (Linter) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Code Review Agent Run #3822e5

Actionable Suggestions - 0

Review Details

• Files reviewed - 3 · Commit Range: 521d1f6..fc9317c

  • superset-frontend/src/SqlLab/components/QueryTable/index.tsx
  • superset-frontend/src/SqlLab/components/QueryTable/styles.ts
  • superset-frontend/src/SqlLab/components/ResultSet/index.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[LevisNgigi]

LGTM!!