fix: Query history view button in SqlLab by geido · Pull Request #36540 · apache/superset

geido · 2025-12-11T17:11:33Z

User description

SUMMARY

Restore the View button in SQL Lab query history so it opens the query modal. Previously, clicking on the button would not open it.

BEFORE:

514383589-65034926-ebc2-44c7-951d-1b62ff105c62.mp4

AFTER:

521846544-6238aca4-8e86-4b49-9736-15f86f334caf.mp4

TESTING INSTRUCTIONS

Navigate to SQL lab
Select the Query history tab
Click on the view button of one of the listed queries - a query modal should now open.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

CodeAnt-AI Description

Restore View button in SQL Lab query history to open Data preview modal

What Changed

The "View" button is shown only for queries that have stored results and opens a "Data preview" modal when clicked
Opening the modal fetches the query results (and starts the query if needed), and closing the modal clears fetched results
The modal content is height-constrained so large result sets display with a fixed scrollable area; the result component gained a mode to render with a fixed height
Unit tests added to verify the View button visibility, that the modal opens and displays "Data preview", and that the modal closes correctly

Impact

✅ Can preview query results from SQL Lab history
✅ Data preview modal opens and closes reliably
✅ Consistent modal height for large result sets

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

codeant-ai-for-open-source · 2025-12-11T17:11:37Z

CodeAnt AI is reviewing your PR.

github-actions · 2025-12-11T17:12:28Z

🎪 Showtime is building environment on GHA for 70eb9a7

codeant-ai-for-open-source · 2025-12-11T17:17:41Z

CodeAnt AI finished reviewing your PR.

codeant-ai-for-open-source · 2025-12-11T17:17:43Z

💡 Enhance Your PR Reviews

We noticed that 3 feature(s) are not configured for this repository. Enabling these features can help improve your code quality and workflow:

🚦 Quality Gates

Status: Quality Gates are not enabled at the organization level
Learn more about Quality Gates

🎫 Jira Ticket Compliance

Status: Jira credentials file not found. Please configure Jira integration in your settings
Learn more about Jira Integration

⚙️ Custom Rules

Status: No custom rules configured. Add rules via organization settings or .codeant/review.json in your repository
Learn more about Custom Rules

Want to enable these features? Contact your organization admin or check our documentation for setup instructions.

github-actions · 2025-12-11T17:24:57Z

🎪 Showtime deployed environment on GHA for 70eb9a7

• Environment: http://35.87.202.32:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

…o/fix/view-results-sqllab

codeant-ai-for-open-source · 2025-12-12T15:37:05Z

CodeAnt AI is running Incremental review

github-actions · 2025-12-15T10:53:25Z

🎪 Showtime deployed environment on GHA for f5c9724

• Environment: http://54.187.51.3:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

codeant-ai-for-open-source · 2025-12-29T14:59:53Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

…o/fix/view-results-sqllab

bito-code-review · 2025-12-29T16:06:09Z

Code Review Agent Run #31996e

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 70eb9a7..3287b2d
- superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.tsx
- superset-frontend/src/SqlLab/components/QueryTable/index.tsx
- superset-frontend/src/SqlLab/components/QueryTable/styles.ts
- superset-frontend/src/SqlLab/components/ResultSet/index.tsx
Files skipped - 0
Tools
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

codeant-ai-for-open-source · 2025-12-31T12:34:19Z

CodeAnt AI is running Incremental review

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

github-actions · 2025-12-31T12:40:21Z

🎪 Showtime is building environment on GHA for 9e780b0

github-actions · 2025-12-31T12:58:28Z

🎪 Showtime deployed environment on GHA for 9e780b0

• Environment: http://35.88.214.15:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically

bito-code-review · 2025-12-31T13:36:14Z

Code Review Agent Run #9d4bac

Actionable Suggestions - 0

Review Details

Files reviewed - 4 · Commit Range: 3287b2d..9e780b0
- superset-frontend/src/SqlLab/components/QueryTable/QueryTable.test.tsx
- superset-frontend/src/SqlLab/components/QueryTable/index.tsx
- superset-frontend/src/SqlLab/components/QueryTable/styles.ts
- superset-frontend/src/SqlLab/components/ResultSet/index.tsx
Files skipped - 0
Tools
- Eslint (Linter) - ✔︎ Successful
- Whispers (Secret Scanner) - ✔︎ Successful
- Detect-secrets (Secret Scanner) - ✔︎ Successful

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

/review - Manually triggers a full AI review.
/pause - Pauses automatic reviews on this pull request.
/resume - Resumes automatic reviews.
/resolve - Marks all Bito-posted review comments as resolved.
/abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

AI Code Review powered by

fix: Query history view button in SqlLab

70eb9a7

pull-request-size Bot added the size/L label Dec 11, 2025

geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Dec 11, 2025

dosubot Bot added the sqllab:query:history label Dec 11, 2025

github-actions Bot added 🎪 70eb9a7 🚦 building and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Dec 11, 2025

codeant-ai-for-open-source Bot added the size:L This PR changes 100-499 lines, ignoring generated files label Dec 11, 2025

github-actions Bot added 🎪 70eb9a7 🚦 deploying and removed 🎪 70eb9a7 🚦 building labels Dec 11, 2025

Merge branch 'master' of https://github.com/apache/superset into geid…

f5c9724

…o/fix/view-results-sqllab

github-actions Bot added 🎪 f5c9724 🚦 building labels Dec 12, 2025

github-actions Bot added 🎪 f5c9724 🚦 running and removed 🎪 f5c9724 🚦 running labels Dec 15, 2025

github-actions Bot removed 🎪 f5c9724 ⌛ 48h labels Dec 17, 2025

chore: Improve readability

3287b2d

Merge branch 'master' of https://github.com/apache/superset into geid…

1b60f61

…o/fix/view-results-sqllab

msyavuz approved these changes Dec 29, 2025

View reviewed changes

Comment thread superset-frontend/src/SqlLab/components/QueryTable/styles.ts Outdated

fix: Styles

9e780b0

geido added the 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR label Dec 31, 2025

github-actions Bot added 🎪 9e780b0 🚦 building 🎪 ⌛ 48h Environment expires after 48 hours (default) and removed 🎪 ⚡ showtime-trigger-start Create new ephemeral environment for this PR labels Dec 31, 2025

github-actions Bot added 🎪 9e780b0 🚦 deploying and removed 🎪 9e780b0 🚦 building labels Dec 31, 2025

justinpark mentioned this pull request Jan 23, 2026

fix(sqllab): invalid height in ResultTable #37408

Open

9 tasks

Conversation

geido commented Dec 11, 2025 • edited by codeant-ai-for-open-source Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

User description

SUMMARY

BEFORE:

AFTER:

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

CodeAnt-AI Description

What Changed

Impact

Checking Your Pull Request

Talking to CodeAnt AI

Example

Preserve Org Learnings with CodeAnt

Example

Retrigger review

Check Your Repository Health

Uh oh!

codeant-ai-for-open-source Bot commented Dec 11, 2025

Uh oh!

github-actions Bot commented Dec 11, 2025

Uh oh!

codeant-ai-for-open-source Bot commented Dec 11, 2025

Uh oh!

codeant-ai-for-open-source Bot commented Dec 11, 2025

💡 Enhance Your PR Reviews

🚦 Quality Gates

🎫 Jira Ticket Compliance

⚙️ Custom Rules

Uh oh!

github-actions Bot commented Dec 11, 2025

Uh oh!

codeant-ai-for-open-source Bot commented Dec 12, 2025

Uh oh!

github-actions Bot commented Dec 15, 2025

Uh oh!

codeant-ai-for-open-source Bot commented Dec 29, 2025

Thanks for using CodeAnt! 🎉

Uh oh!

bito-code-review Bot commented Dec 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #31996e

Uh oh!

Uh oh!

codeant-ai-for-open-source Bot commented Dec 31, 2025

Thanks for using CodeAnt! 🎉

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

github-actions Bot commented Dec 31, 2025

Uh oh!

bito-code-review Bot commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Agent Run #9d4bac

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

geido commented Dec 11, 2025 •

edited by codeant-ai-for-open-source Bot

Loading

bito-code-review Bot commented Dec 29, 2025 •

edited

Loading

bito-code-review Bot commented Dec 31, 2025 •

edited

Loading