Skip to content

fix(dashboard): ensure charts re-render when visibility state changes #36011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgabryje merged 6 commits into from
Nov 19, 2025
Merged

fix(dashboard): ensure charts re-render when visibility state changes #36011

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bfbbc82
fix(dashboard): ensure charts re-render when visibility state changes
richardfogaca Nov 5, 2025
dfa08af
fix: ensure charts always re-render when becoming visible
richardfogaca Nov 13, 2025
94c70fb
fix(dashboard): simplify Chart memo comparison and restore componentI…
richardfogaca Nov 17, 2025
3249c81
fix(dashboard): add componentId check to Chart memo comparison
richardfogaca Nov 17, 2025
1169e36
test(dashboard): add tests for Chart memo comparison logic
richardfogaca Nov 17, 2025
9eed0e8
chore: solve prettier issues
richardfogaca Nov 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions superset-frontend/src/dashboard/components/gridComponents/Chart/Chart.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -612,18 +612,18 @@ export default memo(Chart, (prevProps, nextProps) => {
return false;
}
return (
!nextProps.isComponentVisible ||
(prevProps.isInView === nextProps.isInView &&
prevProps.componentId === nextProps.componentId &&
prevProps.id === nextProps.id &&
prevProps.dashboardId === nextProps.dashboardId &&
prevProps.extraControls === nextProps.extraControls &&
prevProps.handleToggleFullSize === nextProps.handleToggleFullSize &&
prevProps.isFullSize === nextProps.isFullSize &&
prevProps.setControlValue === nextProps.setControlValue &&
prevProps.sliceName === nextProps.sliceName &&
prevProps.updateSliceName === nextProps.updateSliceName &&
prevProps.width === nextProps.width &&
prevProps.height === nextProps.height)
prevProps.isComponentVisible === nextProps.isComponentVisible &&
Comment thread
richardfogaca marked this conversation as resolved.
Outdated
prevProps.isInView === nextProps.isInView &&
prevProps.componentId === nextProps.componentId &&
prevProps.id === nextProps.id &&
prevProps.dashboardId === nextProps.dashboardId &&
prevProps.extraControls === nextProps.extraControls &&
prevProps.handleToggleFullSize === nextProps.handleToggleFullSize &&
prevProps.isFullSize === nextProps.isFullSize &&
prevProps.setControlValue === nextProps.setControlValue &&
prevProps.sliceName === nextProps.sliceName &&
prevProps.updateSliceName === nextProps.updateSliceName &&
prevProps.width === nextProps.width &&
prevProps.height === nextProps.height
Comment thread
richardfogaca marked this conversation as resolved.
Outdated
);
});
Loading