Skip to content

test(dashboard): strengthen fontWeightStrong assertion for markdown bold #35872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sadpandajoe merged 1 commit into from
Oct 29, 2025
Merged

test(dashboard): strengthen fontWeightStrong assertion for markdown bold #35872

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions superset-frontend/src/dashboard/components/gridComponents/Markdown/Markdown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,10 +426,11 @@ test('should have fontWeightStrong in theme for bold markdown rendering', async
},
});

// CRITICAL: Verify fontWeightStrong exists in the theme
// CRITICAL: Verify fontWeightStrong exists in the theme with adequate weight
// If it's missing from allowedAntdTokens, GlobalStyles.tsx:66 will set
// font-weight: undefined on <strong> tags, breaking bold markdown rendering
// Ant Design default is 600, backend config sets 500, either is acceptable
// Must be >= 600 (semibold) to show a true visual difference when bolded
// Values < 600 (like 500/medium) are too subtle and appear similar to normal (400)
expect(supersetTheme.fontWeightStrong).toBeDefined();
expect(supersetTheme.fontWeightStrong).toBeGreaterThan(400);
expect(supersetTheme.fontWeightStrong).toBeGreaterThanOrEqual(600);
});
Loading