test(dashboard): strengthen fontWeightStrong assertion for markdown bold

[sadpandajoe]

SUMMARY

Follow up to #35821, where the test was looking for anything greater than 400. Update test to require fontWeightStrong >= 600 (semibold) instead of > 400. This ensures the theme token has adequate weight to show a true visual difference when bold text is rendered.

Values < 600 (like 500/medium) are too subtle and appear similar to normal weight (400), making bold text barely distinguishable. The stricter assertion catches this inadequate configuration.

🤖 Generated with Claude Code

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #7a7f43

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: b8ec243..b8ec243

  • superset-frontend/src/dashboard/components/gridComponents/Markdown/Markdown.test.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Default Agent You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[korbit-ai]

I've completed my review and didn't find any issues.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[bito-code-review]

Interaction Diagram by Bito

sequenceDiagram
participant Config as Backend Config<br/>🔄 Updated | ●●● High
participant Theme as supersetTheme
participant GlobalStyles as GlobalStyles.tsx<br/>🟩 Added | ●●○ Medium
participant Markdown as Markdown Component
participant SafeMarkdown as SafeMarkdown
participant Test as Markdown.test.tsx<br/>🔄 Updated | ●●● High
Config->>Theme: fontWeightStrong: 600
Theme->>GlobalStyles: Apply font-weight to strong tags
GlobalStyles->>Markdown: CSS: strong &#123; font-weight: 600; &#125;
Markdown->>SafeMarkdown: Render markdown with **bold**
SafeMarkdown-->>Markdown: Render <strong> with 600 weight
Test->>Theme: Verify fontWeightStrong >= 600
Theme-->>Test: Assertion passes

Loading

Critical path: Backend Config->supersetTheme->GlobalStyles.tsx->Markdown Component->SafeMarkdown; Test validates theme value >= 600

Note: The test assertion was tightened to require fontWeightStrong >= 600 (semibold) instead of > 400, with clarified rationale that lower values lack visual distinction. This drives a configuration update where the backend fontWeightStrong must be increased from 500 to 600 to ensure bold markdown text renders with adequate visual contrast.

[github-actions]

🎪 Showtime is building environment on GHA for b8ec243

[github-actions]

🎪 Showtime deployed environment on GHA for b8ec243

• Environment: http://54.245.149.242:8080 (admin/admin)
• Lifetime: 48h auto-cleanup
• Updates: New commits create fresh environments automatically