Skip to content

fix(slice): Fix using isdigit when id passed as int#35452

Merged
Antonio-RiveroMartnez merged 1 commit into
apache:masterfrom
Antonio-RiveroMartnez:fix_slice_filter
Oct 2, 2025
Merged

fix(slice): Fix using isdigit when id passed as int#35452
Antonio-RiveroMartnez merged 1 commit into
apache:masterfrom
Antonio-RiveroMartnez:fix_slice_filter

fix(slice): Fix using isdigit when id passed as int

d4b131c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 2, 2025 in 0s

71.86% (+71.86%) compared to 5493e2c

View this Pull Request on Codecov

71.86% (+71.86%) compared to 5493e2c

Details

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.86%. Comparing base (5493e2c) to head (d4b131c).

Files with missing lines Patch % Lines
superset/models/slice.py 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master   #35452       +/-   ##
===========================================
+ Coverage        0   71.86%   +71.86%     
===========================================
  Files           0      589      +589     
  Lines           0    43559    +43559     
  Branches        0     4711     +4711     
===========================================
+ Hits            0    31302    +31302     
- Misses          0    11024    +11024     
- Partials        0     1233     +1233     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.