Skip to content

fix(slice): Fix using isdigit when id passed as int #35452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Antonio-RiveroMartnez merged 1 commit into from
Oct 2, 2025
+4 −1
Merged

fix(slice): Fix using isdigit when id passed as int #35452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset/models/slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,7 +367,9 @@ def get(cls, id_or_uuid: str) -> Slice:
return qry.one_or_none()


def id_or_uuid_filter(id_or_uuid: str) -> BinaryExpression:
def id_or_uuid_filter(id_or_uuid: str | int) -> BinaryExpression:
if isinstance(id_or_uuid, int):
return Slice.id == id_or_uuid
if id_or_uuid.isdigit():
return Slice.id == int(id_or_uuid)
return Slice.uuid == id_or_uuid
Expand Down
1 change: 1 addition & 0 deletions tests/unit_tests/models/slice_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ def test_slice_get_no_type_error(self, test_name, input_value):
("numeric_id", "123"),
("uuid_format", "550e8400-e29b-41d4-a716-446655440000"),
("invalid_string", "not-a-number"),
("integer_id", 123),
]
)
def test_id_or_uuid_filter(self, test_name, input_value):
Expand Down
Loading