chore(deps): downgrade pyarrow to v16#34693
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #34693 +/- ##
===========================================
+ Coverage 0 72.80% +72.80%
===========================================
Files 0 574 +574
Lines 0 41667 +41667
Branches 0 4390 +4390
===========================================
+ Hits 0 30335 +30335
- Misses 0 10168 +10168
- Partials 0 1164 +1164
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
pyproject.toml
Outdated
| "python-dotenv", # optional dependencies for Flask but required for Superset, see https://flask.palletsprojects.com/en/stable/installation/#optional-dependencies | ||
| "python-geohash", | ||
| "pyarrow>=18.1.0, <19", | ||
| "pyarrow>=16.1.0, <17", |
There was a problem hiding this comment.
If we cannot upgrade, can we add a comment on why and what is the condition to lift this range?
There was a problem hiding this comment.
i added a comment. let me know if it is clear.
|
By downgrading this, will it initially reintroduce the issue that #31476 was trying to fix? |
pyarrow 16 has support for the StringView types that I wanted to upgrade pyarrow for, so this PR shouldn't break that. Thanks @drummerwolli for catching this. |
|
Hi together @phillipleblanc @sadpandajoe @drummerwolli With this downgrade a critical CVE will come back to superset with CVSS V3 CISA-APP score 9.8 It should be may be considered to update to the fixed version V17.0.0 (or newer) and not again downgrade to an affected version? Hint: I expecially don't name the CVE details here, all actual scanner find them in all current superset versions 4.x ( AWS ECR scan marks this a critical finding |
SUMMARY
some database connectors are not supporting the newer pyarrow version (introduced in #31476) yet, or require first an upgrade to SQLAlchemy 2.0. see #34692
fyi @phillipleblanc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION