Skip to content

Comments

chore(deps): Upgrade pyarrow to 18.1.0#31476

Merged
rusackas merged 5 commits intoapache:masterfrom
phillipleblanc:phillip/241216-fix-pyarrow-version
May 1, 2025
Merged

chore(deps): Upgrade pyarrow to 18.1.0#31476
rusackas merged 5 commits intoapache:masterfrom
phillipleblanc:phillip/241216-fix-pyarrow-version

Conversation

@phillipleblanc
Copy link
Contributor

SUMMARY

Upgrade pyarrow to 18.1.0, to support the StringView arrow type.

TESTING INSTRUCTIONS

Start Superset and verify that the SQL Lab queries are still working.

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Update PyArrow dependency to support StringView type #31475
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.65%. Comparing base (76d897e) to head (d451881).
Report is 1815 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #31476       +/-   ##
===========================================
+ Coverage   60.48%   84.65%   +24.16%     
===========================================
  Files        1931      556     -1375     
  Lines       76236    50426    -25810     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    42688     -3426     
+ Misses      28017     7738    -20279     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 48.73% <ø> (-0.43%) ⬇️
javascript ?
mysql 76.87% <ø> (?)
postgres 76.91% <ø> (?)
presto 53.64% <ø> (-0.16%) ⬇️
python 84.65% <ø> (+21.14%) ⬆️
sqlite 76.40% <ø> (?)
unit 62.57% <ø> (+4.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This is a biiiig bump, fingers crossed this doesn't break anything. But I assume we should have adequate coverage to protect against these types of upgrade regressions.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing to "Request changes" to update the dependency bounds.

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@phillipleblanc
Copy link
Contributor Author

@villebro I've updated the dependency bounds

@rusackas
Copy link
Member

Running CI 🤞

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to update requirements/development.txt, too, as that is pinning pyarrow==14.0.2. Optimally, you should run the uv commands for this.

@phillipleblanc
Copy link
Contributor Author

Thanks, I've run the uv command to update both requirements/base.txt and requirements/development.txt.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - it appears the docker build step is failing, but I believe it's unrelated. I'll try to restart CI, but it may well be that something needs to be fixed on master before we can get this working..

@rusackas
Copy link
Member

Closing/reopening to kick start CI again. Hopefully we can get this merged.

@rusackas rusackas closed this Apr 30, 2025
@rusackas rusackas reopened this Apr 30, 2025
@rusackas rusackas merged commit 3c60911 into apache:master May 1, 2025
49 checks passed
@rusackas
Copy link
Member

rusackas commented May 1, 2025

Everything passed! Merged! Hopefully we don't see any unintended side effects 🤞

@phillipleblanc phillipleblanc deleted the phillip/241216-fix-pyarrow-version branch May 1, 2025 13:19
LevisNgigi pushed a commit to LevisNgigi/superset that referenced this pull request Jun 18, 2025
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update PyArrow dependency to support StringView type

3 participants