chore(deps): Upgrade pyarrow to 18.1.0#31476
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #31476 +/- ##
===========================================
+ Coverage 60.48% 84.65% +24.16%
===========================================
Files 1931 556 -1375
Lines 76236 50426 -25810
Branches 8568 0 -8568
===========================================
- Hits 46114 42688 -3426
+ Misses 28017 7738 -20279
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
villebro
left a comment
There was a problem hiding this comment.
LGTM. This is a biiiig bump, fingers crossed this doesn't break anything. But I assume we should have adequate coverage to protect against these types of upgrade regressions.
villebro
left a comment
There was a problem hiding this comment.
Changing to "Request changes" to update the dependency bounds.
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
|
@villebro I've updated the dependency bounds |
|
Running CI 🤞 |
villebro
left a comment
There was a problem hiding this comment.
You need to update requirements/development.txt, too, as that is pinning pyarrow==14.0.2. Optimally, you should run the uv commands for this.
|
Thanks, I've run the |
villebro
left a comment
There was a problem hiding this comment.
LGTM - it appears the docker build step is failing, but I believe it's unrelated. I'll try to restart CI, but it may well be that something needs to be fixed on master before we can get this working..
|
Closing/reopening to kick start CI again. Hopefully we can get this merged. |
|
Everything passed! Merged! Hopefully we don't see any unintended side effects 🤞 |
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
SUMMARY
Upgrade pyarrow to 18.1.0, to support the StringView arrow type.
TESTING INSTRUCTIONS
Start Superset and verify that the SQL Lab queries are still working.
ADDITIONAL INFORMATION