Skip to content

Schemas#340

Closed
deniszgonjanin wants to merge 4 commits into
apache:masterfrom
deniszgonjanin:schemas
Closed

Schemas#340
deniszgonjanin wants to merge 4 commits into
apache:masterfrom
deniszgonjanin:schemas

Conversation

@deniszgonjanin
Copy link
Copy Markdown

This PR adds support for specifying database schemas when creating a new database source. I've tested it against redshift. It should address all or parts of the following: #336, #325, and #252, and #217.

To specify a schema, create a data source with the schema specified in the extras, like so:

{
    "metadata_params": {
          "schema":"myschema"
     },
    "engine_params": {
          "connect_args":{
        }
     }
}

Note that it does specify the schema right on the database source, and not on individual tables. I think this is preferable, so that you don't have to specify schemas on every table you create. You can also segment your database sources based on the schema you are using, which is probably what you want anyway.

@landscape-bot
Copy link
Copy Markdown

Code Health
Code quality remained the same when pulling 76f1838 on deniszgonjanin:schemas into af417b6 on airbnb:master.

@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.06%) to 72.559% when pulling 76f1838 on deniszgonjanin:schemas into af417b6 on airbnb:master.

@mistercrunch
Copy link
Copy Markdown
Member

#330 allows specifying the schema when adding the table

graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants