Allowing to specify schema for tables

[mistercrunch]

Database that have schemas have been challenging to integrate properly, this PR allows people to specify the schema when creating a table.
closes #336

[coveralls]

Coverage increased (+0.004%) to 72.487% when pulling f35491c on schema_fix into 3d1fc99 on master.

[deniszgonjanin]

This didn't work for me, but I didn't dig too much as to why exactly. I have an alternative PR that I started before I saw this one, which adds a bit less code and seems to work well: #340

[mistercrunch]

I think having the schema as a table attribute is ideal as the same database entry can be used.

[landscape-bot]

Code quality remained the same when pulling c661056 on airbnb:schema_fix into 1e08b3e on airbnb:master.

[coveralls]

Coverage decreased (-0.007%) to 72.487% when pulling c661056 on schema_fix into 1e08b3e on master.

[coveralls]

Coverage decreased (-0.007%) to 72.487% when pulling c661056 on schema_fix into 1e08b3e on master.

[yml]

thank you a ton @mistercrunch I have been able to create my first slice in caravel using redshift and a fully qualified name schema.table.

[alanmcruickshank]

Thanks from me too. @mistercrunch. I can confirm that specifying schema name at table creation on Postgres works without specifying additional flags in the database creation stage (no parameters passed in the JSON blob)

[shahneil88]

@mistercrunch @alanmcruickshank @yml
I have been trying connecting non public schema in Redshift and it seems to work now 😃
But, I cannot add tables, when I have same table name in multiple schema.

[shahneil88]

I have opened an issue #356

[alanmcruickshank]

I see the same thing. Provided that there aren't any other table names
registered with that name already it works fine. One option would be to
allow qualified names at the table creation stage: specifying name
"schema1.tablename" to distinguish it from "schema2.tablename".

On Fri, 15 Apr 2016 04:55 Neil Shah, notifications@github.com wrote:

I have opened an issue #356 #356

—
You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#330 (comment)

---

Alan Cruickshank
E: alanmcruickshank@gmail.com
T: +44 770 6851825