build(deps): remove legacy browser polyfills #33853
Conversation
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
|
Based on your review schedule, I'll hold off on reviewing this PR until it's marked as ready for review. If you'd like me to take a look now, comment
|
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Missing Test Environment File Validation ▹ view | 🧠 Not in standard |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/preamble.ts | ✅ |
| superset-frontend/jest.config.js | ✅ |
| superset-frontend/packages/superset-ui-core/src/connection/callApi/callApi.ts | ✅ |
| superset-frontend/webpack.config.js | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
| '^@superset-ui/([^/]+)$': '<rootDir>/node_modules/@superset-ui/$1/src', | ||
| }, | ||
| testEnvironment: 'jsdom', | ||
| testEnvironment: '<rootDir>/spec/helpers/jsDomWithFetchAPI.ts', |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mistercrunch
left a comment
mistercrunch
left a comment
There was a problem hiding this comment.
LGTM, but leaving open in case there's a reviewer closer to the matter. There's probably more cleanup possible up and around this.
Related to cleanup, I think we might have some unused deps and/or devDeps laying around. Would be really neat if we could take one an analysis of each package thinking "do we really still need this?" for each lib.
|
Yes, there are plenty of deps plus dev-deps we can revisit to assess their necessity. Spoiler alert: more upcoming PRs from me on this aspect ;) |
Quite the opposite of a spoiler :) you'll be unspoiling here :) |
* fix(logo): fix logo url typo (apache#33867) * chore(Icons): Add UsergroupAddOutlined icon (apache#33866) * fix(api): Added uuid as a valid search column (apache#33833) * fix(native filters): Make the Apply button available after click on Clear All (apache#33834) * build(deps): remove legacy browser polyfills (apache#33853) Signed-off-by: hainenber <[email protected]> * build(dev-deps): update `fetch-mock` to v11 (apache#33854) Signed-off-by: hainenber <[email protected]> * build(be/deps): replace `importlib_metadata` usage with native Python 3.10+ `importlib.metadata` (apache#33868) Signed-off-by: hainenber <[email protected]> * chore: Updates files related to 5.0.0 release (apache#33869) * chore(docs): bump references to docker image versions upon release of 5.0.0 (apache#33872) --------- Signed-off-by: hainenber <[email protected]> Co-authored-by: Levis Mbote <[email protected]> Co-authored-by: Enzo Martellucci <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Vitor Avila <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Sam Firke <[email protected]>
Signed-off-by: hainenber <[email protected]>
3 participants
build(deps): remove legacy browser polyfills
SUMMARY
Remove polyfills for
fetchandabortcontrollerthat are no longer relevant thanks to built-in support modern browsers.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION