Skip to content

Conversation

@withnale
Copy link
Contributor

@withnale withnale commented Jun 19, 2025

SUMMARY

This provides a simple fix for #33755 and allows for searches to be made to the raw REST apis based on uuid parameters

ADDITIONAL INFORMATION

  • Has associated issue: Fixes Querying for the existence of a given resource UUID #33755
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions github-actions bot added the api Related to the REST API label Jun 19, 2025
Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've completed my review and didn't find any issues.

Files scanned
File Path Reviewed
superset/queries/api.py
superset/charts/api.py
superset/datasets/api.py
superset/dashboards/api.py

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

@codecov
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.88%. Comparing base (76d897e) to head (c3f6e8b).
Report is 1997 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #33833       +/-   ##
===========================================
+ Coverage   60.48%   72.88%   +12.39%     
===========================================
  Files        1931      559     -1372     
  Lines       76236    40402    -35834     
  Branches     8568     4245     -4323     
===========================================
- Hits        46114    29448    -16666     
+ Misses      28017     9857    -18160     
+ Partials     2105     1097     -1008     
Flag Coverage Δ
hive 47.19% <ø> (-1.97%) ⬇️
javascript ?
mysql 71.87% <ø> (?)
postgres 71.93% <ø> (?)
presto 50.95% <ø> (-2.85%) ⬇️
python 72.85% <ø> (+9.34%) ⬆️
sqlite 71.44% <ø> (?)
unit 100.00% <ø> (+42.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@withnale withnale force-pushed the superset-uuid-query branch from befb8c0 to c3f6e8b Compare June 23, 2025 08:43
@rusackas rusackas merged commit 4dc3dd0 into apache:master Jun 23, 2025
54 checks passed
@rusackas rusackas added the review:checkpoint Last PR reviewed during the daily review standup label Jun 23, 2025
amaannawab923 added a commit to amaannawab923/superset that referenced this pull request Jun 24, 2025
* fix(logo): fix logo url typo (apache#33867)

* chore(Icons): Add UsergroupAddOutlined icon (apache#33866)

* fix(api): Added uuid as a valid search column (apache#33833)

* fix(native filters): Make the Apply button available after click on Clear All (apache#33834)

* build(deps): remove legacy browser polyfills (apache#33853)

Signed-off-by: hainenber <[email protected]>

* build(dev-deps): update `fetch-mock` to v11 (apache#33854)

Signed-off-by: hainenber <[email protected]>

* build(be/deps): replace `importlib_metadata` usage with native  Python 3.10+ `importlib.metadata`  (apache#33868)

Signed-off-by: hainenber <[email protected]>

* chore: Updates files related to 5.0.0 release (apache#33869)

* chore(docs): bump references to docker image versions upon release of 5.0.0 (apache#33872)

---------

Signed-off-by: hainenber <[email protected]>
Co-authored-by: Levis Mbote <[email protected]>
Co-authored-by: Enzo Martellucci <[email protected]>
Co-authored-by: Paul Rhodes <[email protected]>
Co-authored-by: Vitor Avila <[email protected]>
Co-authored-by: Đỗ Trọng Hải <[email protected]>
Co-authored-by: Michael S. Molina <[email protected]>
Co-authored-by: Sam Firke <[email protected]>
@sadpandajoe sadpandajoe removed the review:checkpoint Last PR reviewed during the daily review standup label Jun 24, 2025
LisaHusband pushed a commit to LisaHusband/superset that referenced this pull request Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Related to the REST API size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Querying for the existence of a given resource UUID

3 participants