-
Notifications
You must be signed in to change notification settings - Fork 16.1k
fix(api): Added uuid as a valid search column #33833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've completed my review and didn't find any issues.
Files scanned
| File Path | Reviewed |
|---|---|
| superset/queries/api.py | ✅ |
| superset/charts/api.py | ✅ |
| superset/datasets/api.py | ✅ |
| superset/dashboards/api.py | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #33833 +/- ##
===========================================
+ Coverage 60.48% 72.88% +12.39%
===========================================
Files 1931 559 -1372
Lines 76236 40402 -35834
Branches 8568 4245 -4323
===========================================
- Hits 46114 29448 -16666
+ Misses 28017 9857 -18160
+ Partials 2105 1097 -1008
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
befb8c0 to
c3f6e8b
Compare
* fix(logo): fix logo url typo (apache#33867) * chore(Icons): Add UsergroupAddOutlined icon (apache#33866) * fix(api): Added uuid as a valid search column (apache#33833) * fix(native filters): Make the Apply button available after click on Clear All (apache#33834) * build(deps): remove legacy browser polyfills (apache#33853) Signed-off-by: hainenber <[email protected]> * build(dev-deps): update `fetch-mock` to v11 (apache#33854) Signed-off-by: hainenber <[email protected]> * build(be/deps): replace `importlib_metadata` usage with native Python 3.10+ `importlib.metadata` (apache#33868) Signed-off-by: hainenber <[email protected]> * chore: Updates files related to 5.0.0 release (apache#33869) * chore(docs): bump references to docker image versions upon release of 5.0.0 (apache#33872) --------- Signed-off-by: hainenber <[email protected]> Co-authored-by: Levis Mbote <[email protected]> Co-authored-by: Enzo Martellucci <[email protected]> Co-authored-by: Paul Rhodes <[email protected]> Co-authored-by: Vitor Avila <[email protected]> Co-authored-by: Đỗ Trọng Hải <[email protected]> Co-authored-by: Michael S. Molina <[email protected]> Co-authored-by: Sam Firke <[email protected]>
SUMMARY
This provides a simple fix for #33755 and allows for searches to be made to the raw REST apis based on uuid parameters
ADDITIONAL INFORMATION