Skip to content

fix: Makes time compare migration more resilient #33592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michael-s-molina merged 3 commits into from
May 27, 2025
Merged

fix: Makes time compare migration more resilient #33592

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
08488e9
fix: Makes time compare migration more resilient
michael-s-molina May 27, 2025
9a79a9f
Handle empty values
michael-s-molina May 27, 2025
02de70c
Use walrus
michael-s-molina May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion superset/migrations/shared/migrate_viz/processors.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,9 @@ def _pre_action(self) -> None:

if time_compare := self.data.get("time_compare"):
self.data["time_compare"] = [
value + " ago" for value in as_list(time_compare) if value
value if value.endswith(" ago") else value + " ago"
for value in as_list(time_compare)
if value
Comment thread
michael-s-molina marked this conversation as resolved.
Outdated
]

comparison_type = self.data.get("comparison_type") or "values"
Expand Down