fix: Makes time compare migration more resilient

[michael-s-molina]

SUMMARY

While testing 5.0, we noticed that some users manually entered time compare values like 1 year ago that are valid for ECharts visualizations but not for legacy visualizations. We also found empty time compare values instead of an empty list. This fix makes the migration more resilient by handling these cases.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[korbit-ai]

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.

Category	Issue	Status
	Inefficient String Operations in List Comprehension ▹ view	🧠 Not in standard

Files scanned

​

File Path	Reviewed
superset/migrations/shared/migrate_viz/processors.py	✅

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.02%. Comparing base (76d897e) to head (02de70c).
⚠️ Report is 3194 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #33592       +/-   ##
===========================================
+ Coverage   60.48%   83.02%   +22.53%     
===========================================
  Files        1931      554     -1377     
  Lines       76236    40670    -35566     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    33766    -12348     
+ Misses      28017     6904    -21113     
+ Partials     2105        0     -2105     

Flag	Coverage Δ
hive	47.64% <0.00%> (-1.52%)	⬇️
javascript	?
mysql	74.18% <0.00%> (?)
postgres	74.24% <0.00%> (?)
presto	52.02% <0.00%> (-1.79%)	⬇️
python	83.02% <100.00%> (+19.51%)	⬆️
sqlite	73.74% <0.00%> (?)
unit	61.52% <100.00%> (+3.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.