Skip to content

fix: remove --no-optional from docker-compose build #29779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mistercrunch merged 3 commits into from
Jul 30, 2024
Merged

fix: remove --no-optional from docker-compose build #29779

mistercrunch merged 3 commits into from
Jul 30, 2024

Conversation

@mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jul 30, 2024

Remove unusual artifact from local docker-compose setup, using vanilla npm install

@dosubot dosubot bot added dependencies:npm install:docker Installation - docker container labels Jul 30, 2024
rusackas
rusackas reviewed Jul 30, 2024
View reviewed changes
@mistercrunch mistercrunch mentioned this pull request Jul 30, 2024
Merged
9 tasks
mistercrunch
mistercrunch commented Jul 30, 2024
View reviewed changes
docker/docker-frontend.sh
if [ "$BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" ]; then
echo "Building Superset frontend in dev mode inside docker container"
cd /app/superset-frontend
npm install -f --no-optional --global webpack webpack-cli
Copy link
Member Author

@mistercrunch mistercrunch Jul 30, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not needed

@mistercrunch mistercrunch merged commit 6bf8596 into master Jul 30, 2024
@rusackas rusackas deleted the no_no_optional branch July 30, 2024 21:46
@sadpandajoe
Copy link
Member

sadpandajoe commented Jul 30, 2024

@supersetbot label 4.1

@github-actions github-actions bot added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Jul 30, 2024
@sadpandajoe
Copy link
Member

sadpandajoe commented Aug 1, 2024

@supersetbot unlabel 4.1

@github-actions github-actions bot removed the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 1, 2024
This was referenced Aug 5, 2024
Merged
Merged
nyohasstium pushed a commit to Webgains/superset that referenced this pull request Jan 2, 2025
@mistercrunch @nyohasstium
fix: remove --no-optional from docker-compose build (apache#29779)
4562657
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 5.0.0 First shipped in 5.0.0 labels Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rusackas rusackas rusackas approved these changes

Assignees

No one assigned

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels install:docker Installation - docker container size/S 🚢 5.0.0 First shipped in 5.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mistercrunch @sadpandajoe @rusackas