fix(frontend/docker, ci): fix borked Docker build due to Lerna v8 uplift #29725
Conversation
Signed-off-by: hainenber <[email protected]>
Signed-off-by: hainenber <[email protected]>
| cd /app/superset-frontend | ||
| npm install -f --no-optional --global webpack webpack-cli | ||
| npm install -f --no-optional | ||
| npm install -f |
There was a problem hiding this comment.
@mistercrunch I saw this flag was added previously but unsure the context. I believe there's a historical reason for it? 👀
There was a problem hiding this comment.
I did some git archeology and it looks like --no-optional goes back to #10766 (2020) and there's not a clear explanation. I vote going vanilla and doing a very simple npm install instead of those 2 lines. Webpack packages should install as its just a devDependencies, and they'll install normally as long as we don't specify --production, which we don't want to do here.
There was a problem hiding this comment.
tagging @eschutho as I believe she ran in an issue similar to the one you're fixing here.
There was a problem hiding this comment.
Hmm... looks like @craig-rueda added that a looooong time ago. I'm not sure if there are any consequences to its removal ¯\_(ツ)_/¯
There was a problem hiding this comment.
eek... duplicated effort. That's what I get for revisiting an open tab without refreshing.
There was a problem hiding this comment.
@rusackas I really think it's ok to remove this --no-optional as it's non-standard and in this context would only apply BUILD_SUPERSET_FRONTEND_IN_DOCKER" = "true" which really should align with other build context (if you're running a dev env outside docker for instance).
There was a problem hiding this comment.
This lgtm. I'll remove the pinned optional dependencies in my pr.
hainenber
changed the title
|
@eschutho I'm not able to reproduce your CI issue as this PR's |
|
My vote is to replace those two lines with a single, simple |
|
The webpack install is not necessary, simplifying further here #29779 |
|
@supersetbot label 4.1 |
github-actions
bot
added
the
v4.1
|
@supersetbot unlabel 4.1 |
github-actions
bot
removed
the
v4.1
sadpandajoe
added
the
v4.1
…ift (#29725) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 8891f04)
…ift (apache#29725) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 8891f04)
mistercrunch
added
🍒 4.1.1
…ift (apache#29725) Signed-off-by: hainenber <[email protected]> (cherry picked from commit 8891f04)
mistercrunch
added
🍒 4.1.3
5 participants
fix(frontend/docker, ci): fix borked Docker build due to Lerna v8 uplift
SUMMARY
Closes #29658
Remove
--no-optionalindocker-frontend.shto allow installing@nxoptional dependencies which is necessary for Lerna v8Also upgrading
prop-typesto next minor version to assess reproducibility of issue raised in PR #29723BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION