Skip to content

Conversation

@rowdyroad
Copy link
Contributor

@rowdyroad rowdyroad commented Jan 3, 2024

SUMMARY

There is an issue for any chart or filter on embedded dashboard: "An error occurred while rendering the visualization: Error: Item with key "...any viz item..." is not registered."

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2024-01-03 at 02 57 11 Screenshot 2024-01-03 at 02 57 17 Screenshot 2024-01-03 at 03 08 22

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@codecov
Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9033e72) 69.14% compared to head (11d7e52) 69.14%.
Report is 3 commits behind head on master.

Files Patch % Lines
superset-frontend/src/embedded/index.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #26398      +/-   ##
==========================================
- Coverage   69.14%   69.14%   -0.01%     
==========================================
  Files        1946     1946              
  Lines       75989    75990       +1     
  Branches     8479     8479              
==========================================
  Hits        52544    52544              
- Misses      21266    21267       +1     
  Partials     2179     2179              
Flag Coverage Δ
javascript 56.45% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Jan 3, 2024
@john-bodley
Copy link
Member

Thanks @rowdyroad for the fix. This might be a regression from #26379.

@john-bodley john-bodley merged commit 9ffcd64 into apache:master Jan 3, 2024
@michael-s-molina
Copy link
Member

Thank you @rowdyroad for the fix. I didn't know embedded was a separate React app 😉

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch labels Jan 3, 2024
sivasathyaseeelan pushed a commit to sivasathyaseeelan/superset that referenced this pull request Jan 3, 2024
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jan 4, 2024
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Jan 4, 2024
michael-s-molina pushed a commit that referenced this pull request Jan 9, 2024
…r: Item with key ... is not registered. (#26398)

(cherry picked from commit 9ffcd64)
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
…r: Item with key ... is not registered. (apache#26398)

(cherry picked from commit 9ffcd64)
@mistercrunch mistercrunch added 🍒 3.1.0 Cherry-picked to 3.1.0 🍒 3.1.1 Cherry-picked to 3.1.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Mar 8, 2024
@mistercrunch mistercrunch added 🍒 3.1.2 Cherry-picked to 3.1.2 🚢 4.0.0 First shipped in 4.0.0 labels Apr 17, 2024
@mistercrunch mistercrunch added the 🍒 3.1.3 Cherry-picked to 3.1.3 label Jul 2, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.1 Label added by the release manager to track PRs to be included in the 3.1 branch 🍒 3.1.0 Cherry-picked to 3.1.0 🍒 3.1.1 Cherry-picked to 3.1.1 🍒 3.1.2 Cherry-picked to 3.1.2 🍒 3.1.3 Cherry-picked to 3.1.3 🚢 4.0.0 First shipped in 4.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants