fix: Duplicated plugin registration

[michael-s-molina]

SUMMARY

This PR removes the duplicated plugin registration that generates the following type of warning:

Item with key "deck_arc" already exists. You are assigning a new value.
Item with key "deck_arc" already exists. You are assigning a new value.
Item with key "big_number" already exists. You are assigning a new value.
Item with key "box_plot" already exists. You are assigning a new value.

The duplicate registration was necessary when those pages belonged to different React apps. Now, they belong to the same app which makes the registration unnecessary.

The registration should happen only once when the application initializes.

TESTING INSTRUCTIONS

1 - Open any dashboard
2 - Check that the warnings are not there anymore

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.14%. Comparing base (863f8bb) to head (dc37653).
Report is 2232 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #26379      +/-   ##
==========================================
- Coverage   69.18%   69.14%   -0.04%     
==========================================
  Files        1946     1946              
  Lines       75988    75986       -2     
  Branches     8479     8479              
==========================================
- Hits        52570    52541      -29     
- Misses      21228    21266      +38     
+ Partials     2190     2179      -11     

Flag	Coverage Δ
javascript	56.46% <ø> (-0.08%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[alephpt]

Still seeing this problem in 5.0.0. Any advice?

[rusackas]

OMG THANK YOU. That's been nagging at me forever!

LOL, the new comment made me think this was a new PR. This is annoying, and is still an issue. Feel free to file a GitHub issue, or dig into this PR to see what changed since then and investigate a new fix. It'd be appreciated.

[mistercrunch]

Came here with the same idea -> OMG THANK YOU. That's been nagging at me forever!

[michael-s-molina]

There are only 2 places in master calling setupPlugins():

src/views/App.tsx
src/embedded/index.tsx

@Vitor-Avila @rusackas You might want to check if this call is required for Embedded.

[Vitor-Avila]

There are only 2 places in master calling setupPlugins():

src/views/App.tsx src/embedded/index.tsx

@Vitor-Avila @rusackas You might want to check if this call is required for Embedded.

@rusackas are you aware if that's necessary? I'm not sure

[mistercrunch]

Both these calls probably shouldn't be module-scoped ...