Skip to content

Conversation

@rusackas
Copy link
Member

SUMMARY

Fixes the missing controls for the DeckGL multi layer viz plugin.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TEST PLAN

Tested manually, and the screenshot above shows it working, though we may want to look at that data/query preview area in a separate PR (I feel like we've seen this one before)

ADDITIONAL INFORMATION

@rusackas rusackas requested a review from villebro January 12, 2021 18:46
@rusackas rusackas added the rush! Requires immediate attention label Jan 12, 2021
@junlincc junlincc added the hold:testing! On hold for testing label Jan 12, 2021
@junlincc
Copy link
Member

Screen Shot 2021-01-12 at 12 13 42 PM

@rusackas badass Evan🔥🔥 2 p0 release blocker in a roll.

all layout looks good @pkdotson thanks for the fix!

lgtm!

@junlincc junlincc removed the hold:testing! On hold for testing label Jan 12, 2021
@junlincc junlincc self-requested a review January 12, 2021 20:30
@codecov-io
Copy link

codecov-io commented Jan 12, 2021

Codecov Report

Merging #12466 (6691ab7) into master (d8f4443) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12466      +/-   ##
==========================================
- Coverage   66.81%   66.80%   -0.02%     
==========================================
  Files        1015     1015              
  Lines       49548    49644      +96     
  Branches     5080     5123      +43     
==========================================
+ Hits        33106    33163      +57     
- Misses      16312    16351      +39     
  Partials      130      130              
Flag Coverage Δ
cypress 50.99% <ø> (+0.01%) ⬆️
javascript 60.76% <ø> (+0.01%) ⬆️
python 64.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...end/src/visualizations/FilterBox/transformProps.js 52.38% <0.00%> (-26.20%) ⬇️
...rontend/src/visualizations/FilterBox/FilterBox.jsx 67.19% <0.00%> (-4.15%) ⬇️
...set-frontend/src/dashboard/util/getDropPosition.js 92.06% <0.00%> (-1.59%) ⬇️
...nd/src/explore/components/ExploreViewContainer.jsx 80.00% <0.00%> (-0.26%) ⬇️
...ntend/src/dashboard/components/PropertiesModal.jsx 82.88% <0.00%> (ø)
...rontend/src/explore/components/DatasourcePanel.tsx 90.69% <0.00%> (+0.22%) ⬆️
...rset-frontend/src/explore/components/SaveModal.tsx 91.76% <0.00%> (+1.17%) ⬆️
...ntend/src/explore/components/ExploreChartPanel.jsx 80.95% <0.00%> (+6.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8f4443...6691ab7. Read the comment docs.

@rusackas rusackas requested a review from ktmud January 13, 2021 07:25
@rusackas rusackas merged commit 7aba4c2 into apache:master Jan 13, 2021
@rusackas rusackas deleted the bump-superset-ui-deckgl branch January 13, 2021 08:10
@junlincc junlincc added the v1.0 label Jan 13, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021
@junlincc junlincc removed the rush! Requires immediate attention label Jan 15, 2021
etr2460 pushed a commit that referenced this pull request Jan 25, 2021
* release: bump to 1.0.0 and CHANGELOG

* fix(explore): long metric name display (#12387)

* fix(explore): long metric name display

* add tooltip to control

* chore: Show datasets when search input is empty (#12391)

* chore: Fix typo “Rest” to “Reset” (#12392)

* chore: upgrade eslint, babel, and prettier (#12393)

* feat(explore): add tooltip to timepicker label (#12401)

* chore: change Datasource to Dataset in Explore ui (#12402)

* chore(explore):change dataset to datasource in ui

* modal

* Add space

* Changing it back🤦🏾‍♀️

* Chargeback

* fix: Refresh Interval Modal dropdown (#12406)

* fix(native-filters): incorrect queriesData state (#12409)

* refactor: from superset.utils.core break down date_parser (#12408)

* Fixes control panel fields styling (#12236) (#12326)

* feat: Resizable dataset and controls panels on Explore view (#12411)

* Implement resizable panels on explore view

* Optimize chart rendering while resizing

* Make dataset column narrower

Co-authored-by: Evan Rusackas <evan@preset.io>

* fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418)

* [12181] Fix artifacts while drag and dropping deck.gl charts.

* Run prettier

* bump superset-ui packages for rolling window change (#12426)

* chore: bump superset-ui deckgl plugin (#12466)

* fix: do not show vertical scrollbar for charts in dashboard (#12478)

* fix: do not show vertical scrollbar for charts in dashboard

* Proper fix for #11419

Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>

* fix(dashboard): use datasource id from slice metadata (#12483)

* fix(timepicker): make pyparsing thread safe (#12489)

* fix: make pyparsing thread safe

* remove parenthesis for decorator

* fix (SQL Lab): disappearing results on tab switch (#12472)

* fix (SQL Lab): disappearing results on tab switch

* Remove state

* Fix test

* fix: import ZIP files that have been modified (#12425)

* fix: import ZIP files that have been modified

* Add unit test

* update changelog with rc2 entries

* fix: impose dataset ownership check on old API (#12491)

* fix: impose dataset ownership check on old API

* update UPDATING.md

* partially protect the old MVC also

* prevent metric and column add and update

* ci: remove refs/tags from docker tags on a release (#12518)

* ci: remove refs/tags from docker tags on a release

* wider head

* fix: lowercase all columns in examples (#12530)

* fix(explore): time table control panel (#12532)

* fix(explore): Add Time section back to FilterBox (#12537)

* Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536)

* fix: Select options overflowing Save chart modal on Explore view (#12522)

* Fix select options overflowing modal

* fix unit test

Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

* Fix list filters vertical alignment (#12497)

* feat(db-engine): Add support for Apache Solr (#12403)

* [db engine] Add support for Apache Solr

* Fixing typo

* chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337)

* add rc3 changelog entries

* fix: Popover closes on change of dropdowns values (#12410)

* fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555)

* fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556)

* fix: height on grid results (#12558)

* fix: case expression should not have double quotes (#12562)

* Fix 500 error when loading dashboards with slice having deleted dataset (#12535)

* add rc4 changelog entries

* Fixed typo on line 348

* Added files

Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com>
Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com>
Co-authored-by: Geido <60598000+geido@users.noreply.github.com>
Co-authored-by: Junlin Chen <junlin@preset.io>
Co-authored-by: Jesse Yang <jesse.yang@airbnb.com>
Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com>
Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com>
Co-authored-by: Evan Rusackas <evan@preset.io>
Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com>
Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com>
Co-authored-by: Grace Guo <grace.guo@airbnb.com>
Co-authored-by: Beto Dealmeida <roberto@dealmeida.net>
Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>
Co-authored-by: Xiang Fu <fx19880617@gmail.com>
Co-authored-by: Ahmed Adel <github@aadel.io>
Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com>
Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu>
Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>
@mistercrunch mistercrunch added 🍒 1.0.0 Cherry-picked to 1.0.0 🍒 1.0.1 Cherry-picked to 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS v1.0 🍒 1.0.0 Cherry-picked to 1.0.0 🍒 1.0.1 Cherry-picked to 1.0.1 🚢 1.2.0 First shipped in 1.2.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants