chore: Show datasets when search input is empty #12391

geido · 2021-01-09T22:46:19Z

SUMMARY

Shows data in the table when search input is empty. Related to this comment .

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

Are.you.an.ethni.mp4

TEST PLAN

Open a chart
Change the dataset
Search for a dataset
Delete the search string from the input
Make sure the initial data is fetched

ADDITIONAL INFORMATION

…ataset_modal

geido · 2021-01-09T22:54:26Z

@junlincc

codecov-io · 2021-01-09T22:54:30Z

Codecov Report

Merging #12391 (1bd8d53) into master (ff7b789) will decrease coverage by 2.81%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #12391      +/-   ##
==========================================
- Coverage   66.88%   64.06%   -2.82%     
==========================================
  Files        1014      485     -529     
  Lines       49513    29899   -19614     
  Branches     5077        0    -5077     
==========================================
- Hits        33118    19156   -13962     
+ Misses      16264    10743    -5521     
+ Partials      131        0     -131

Flag	Coverage Δ
cypress	`?`
javascript	`?`
python	`64.06% <ø> (-0.16%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/examples/birth_names.py	`73.19% <0.00%> (-25.65%)`	⬇️
superset/common/query_context.py	`82.51% <0.00%> (-3.59%)`	⬇️
superset/extensions.py	`93.15% <0.00%> (-1.37%)`	⬇️
superset/db_engine_specs/presto.py	`82.03% <0.00%> (-1.30%)`	⬇️
superset/sql_lab.py	`79.43% <0.00%> (-0.94%)`	⬇️
superset/connectors/sqla/models.py	`90.58% <0.00%> (-0.92%)`	⬇️
superset/db_engine_specs/hive.py	`83.84% <0.00%> (-0.39%)`	⬇️
superset/db_engine_specs/base.py	`85.82% <0.00%> (-0.26%)`	⬇️
...nd/src/dashboard/containers/DashboardComponent.jsx
...board/components/gridComponents/new/NewDivider.jsx
... and 527 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff7b789...1bd8d53. Read the comment docs.

junlincc · 2021-01-10T16:06:50Z

thanks for the PR!
the new behavior is a bit jumpy, can we set fixed height to the modal, i assume we already have pagination, right?

adam-stasiak · 2021-01-11T09:40:13Z

No other issues found than Junlin. Tested.

villebro

agree with @junlincc, removing jumpiness would be nice.

…_search_empty

geido · 2021-01-11T14:41:10Z

@junlincc Height has been fixed. As for the pagination, does not look like it's there. This retrieves max 20 datasets and shows them. AFTER video updated to reflect the change.

junlincc

LGTM!!

@villebro If the code looks ok, we are good to go!

junlincc · 2021-01-11T15:40:04Z

looks like CI is stuck again??

villebro · 2021-01-11T16:00:31Z

3 pages/72 queued actions, pretty normal 😄

superset-frontend/src/datasource/ChangeDatasourceModal.tsx

…_search_empty

junlincc · 2021-01-11T22:06:48Z

@geido tested again, LGTM! i dont have enough dataset in local, so just want to make sure the scroll bar is enough to take care of a long page of dataset.

junlincc · 2021-01-11T22:36:24Z

@geido also, please open another issue and PR to fix the warning sign and search bar as follow up. 🙏

junlincc · 2021-01-13T07:13:18Z

@geido

i think this issue is introduced by my recent PR fix(explore): fixed table header in chrome. can we have 1.warning msg 2.search bar 3.header all sticky to the top only scroll bar on the table body?
https://user-images.githubusercontent.com/67837651/104417420-2ef92780-552a-11eb-94e1-b2dc99b1ffa2.mov

* release: bump to 1.0.0 and CHANGELOG * fix(explore): long metric name display (#12387) * fix(explore): long metric name display * add tooltip to control * chore: Show datasets when search input is empty (#12391) * chore: Fix typo “Rest” to “Reset” (#12392) * chore: upgrade eslint, babel, and prettier (#12393) * feat(explore): add tooltip to timepicker label (#12401) * chore: change Datasource to Dataset in Explore ui (#12402) * chore(explore):change dataset to datasource in ui * modal * Add space * Changing it back🤦🏾‍♀️ * Chargeback * fix: Refresh Interval Modal dropdown (#12406) * fix(native-filters): incorrect queriesData state (#12409) * refactor: from superset.utils.core break down date_parser (#12408) * Fixes control panel fields styling (#12236) (#12326) * feat: Resizable dataset and controls panels on Explore view (#12411) * Implement resizable panels on explore view * Optimize chart rendering while resizing * Make dataset column narrower Co-authored-by: Evan Rusackas <evan@preset.io> * fix(dashboard): artefacts shown while drag and dropping deck.gl charts (#12418) * [12181] Fix artifacts while drag and dropping deck.gl charts. * Run prettier * bump superset-ui packages for rolling window change (#12426) * chore: bump superset-ui deckgl plugin (#12466) * fix: do not show vertical scrollbar for charts in dashboard (#12478) * fix: do not show vertical scrollbar for charts in dashboard * Proper fix for #11419 Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> * fix(dashboard): use datasource id from slice metadata (#12483) * fix(timepicker): make pyparsing thread safe (#12489) * fix: make pyparsing thread safe * remove parenthesis for decorator * fix (SQL Lab): disappearing results on tab switch (#12472) * fix (SQL Lab): disappearing results on tab switch * Remove state * Fix test * fix: import ZIP files that have been modified (#12425) * fix: import ZIP files that have been modified * Add unit test * update changelog with rc2 entries * fix: impose dataset ownership check on old API (#12491) * fix: impose dataset ownership check on old API * update UPDATING.md * partially protect the old MVC also * prevent metric and column add and update * ci: remove refs/tags from docker tags on a release (#12518) * ci: remove refs/tags from docker tags on a release * wider head * fix: lowercase all columns in examples (#12530) * fix(explore): time table control panel (#12532) * fix(explore): Add Time section back to FilterBox (#12537) * Fixing Pinot queries for time granularities: WEEKS/MONTHS/QUARTERS/YEARS (#12536) * fix: Select options overflowing Save chart modal on Explore view (#12522) * Fix select options overflowing modal * fix unit test Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> * Fix list filters vertical alignment (#12497) * feat(db-engine): Add support for Apache Solr (#12403) * [db engine] Add support for Apache Solr * Fixing typo * chore: rename docker image in build_docker_image.sh, docker-compose.yml and helm values.yaml (#12337) * add rc3 changelog entries * fix: Popover closes on change of dropdowns values (#12410) * fix: Add MAX_SQL_ROW value to LIMIT_DROPDOWN (#12555) * fix(viz): missing groupby and broken adhoc metrics for boxplot (#12556) * fix: height on grid results (#12558) * fix: case expression should not have double quotes (#12562) * Fix 500 error when loading dashboards with slice having deleted dataset (#12535) * add rc4 changelog entries * Fixed typo on line 348 * Added files Co-authored-by: Daniel Gaspar <danielvazgaspar@gmail.com> Co-authored-by: Yongjie Zhao <yongjie.zhao@gmail.com> Co-authored-by: Geido <60598000+geido@users.noreply.github.com> Co-authored-by: Junlin Chen <junlin@preset.io> Co-authored-by: Jesse Yang <jesse.yang@airbnb.com> Co-authored-by: Agata Stawarz <47450693+agatapst@users.noreply.github.com> Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com> Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> Co-authored-by: Kamil Gabryjelski <kamil.gabryjelski@gmail.com> Co-authored-by: Evan Rusackas <evan@preset.io> Co-authored-by: Kasia Kucharczyk <2536609+kkucharc@users.noreply.github.com> Co-authored-by: Phillip Kelley-Dotson <pkelleydotson@yahoo.com> Co-authored-by: Grace Guo <grace.guo@airbnb.com> Co-authored-by: Beto Dealmeida <roberto@dealmeida.net> Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> Co-authored-by: Xiang Fu <fx19880617@gmail.com> Co-authored-by: Ahmed Adel <github@aadel.io> Co-authored-by: Amit Miran <47772523+amitmiran137@users.noreply.github.com> Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com> Co-authored-by: Shuyao Bi <shuyaob@andrew.cmu.edu> Co-authored-by: Lyndsi Kay Williams <lyndsikaywilliams@Lyndsis-MacBook-Pro.local>

geido added 5 commits January 9, 2021 19:50

Closes #12389

c565659

Merge remote-tracking branch 'upstream/master' into fix/issue_12389_d…

fc69b89

…ataset_modal

Search empty string

d3ae8ea

Remove unused imports

1928f94

Fix tests

ab53564

superset-github-bot bot added the Flexiana label Jan 9, 2021

pull-request-size bot added the size/S label Jan 9, 2021

Remove unused import

5e09c72

geido changed the title ~~chore: Dataset show results when search is empty~~ chore: Show datasets when search input is empty Jan 9, 2021

junlincc added the explore:dataset Related to the dataset of Explore label Jan 10, 2021

junlincc requested review from junlincc and villebro January 10, 2021 00:28

villebro reviewed Jan 11, 2021

View reviewed changes

geido added 2 commits January 11, 2021 12:06

Merge remote-tracking branch 'upstream/master' into chore/issue_12389…

6309a15

…_search_empty

Fix height

1bd8d53

geido requested a review from villebro January 11, 2021 14:41

junlincc approved these changes Jan 11, 2021

View reviewed changes

villebro approved these changes Jan 11, 2021

View reviewed changes

nikolagigic approved these changes Jan 11, 2021

View reviewed changes

maloun96 reviewed Jan 11, 2021

View reviewed changes

superset-frontend/src/datasource/ChangeDatasourceModal.tsx Show resolved Hide resolved

geido added 2 commits January 11, 2021 19:31

Merge remote-tracking branch 'upstream/master' into chore/issue_12389…

b6e336d

…_search_empty

Correct height type

9ce5d97

junlincc added the rush! Requires immediate attention label Jan 11, 2021

junlincc merged commit 376723a into apache:master Jan 11, 2021

junlincc mentioned this pull request Jan 11, 2021

[Explore]Change Dataset search can't get back to default list view after filtering #12424

Closed

villebro added the v1.0 label Jan 12, 2021

villebro pushed a commit that referenced this pull request Jan 12, 2021

chore: Show datasets when search input is empty (#12391)

dc203c1

junlincc added #bug:blocking! Blocking issues with high priority and removed rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Jan 12, 2021

geido mentioned this pull request Jan 13, 2021

Explore: Header, warning and table in Datasets modal should be sticky #12492

Closed

amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Jan 14, 2021

chore: Show datasets when search input is empty (apache#12391)

503fc2b

mistercrunch added 🍒 1.0.0 Cherry-picked to 1.0.0 🍒 1.0.1 Cherry-picked to 1.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 First shipped in 1.2.0 labels Mar 12, 2024

chore: Show datasets when search input is empty #12391

chore: Show datasets when search input is empty #12391

Uh oh!

Conversation

geido commented Jan 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

geido commented Jan 9, 2021

Uh oh!

codecov-io commented Jan 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

junlincc commented Jan 10, 2021

Uh oh!

adam-stasiak commented Jan 11, 2021

Uh oh!

villebro left a comment

Choose a reason for hiding this comment

Uh oh!

geido commented Jan 11, 2021

Uh oh!

junlincc left a comment

Choose a reason for hiding this comment

Uh oh!

junlincc commented Jan 11, 2021

Uh oh!

villebro commented Jan 11, 2021

Uh oh!

Uh oh!

junlincc commented Jan 11, 2021

Uh oh!

junlincc commented Jan 11, 2021

Uh oh!

junlincc commented Jan 13, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

geido commented Jan 9, 2021 •

edited

Loading

codecov-io commented Jan 9, 2021 •

edited

Loading