Skip to content

fix(query): sorting by user for Query History list view#11897

Merged
dpgaspar merged 2 commits intoapache:masterfrom
preset-io:tai/fix-query-history-sort
Dec 3, 2020
Merged

fix(query): sorting by user for Query History list view#11897
dpgaspar merged 2 commits intoapache:masterfrom
preset-io:tai/fix-query-history-sort

Conversation

@nytai
Copy link
Copy Markdown
Member

@nytai nytai commented Dec 2, 2020

SUMMARY

Fixing a bug that snuck in with #11702 breaking sorting by user in the list view.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TEST PLAN

  • manually verify that sorting by user in Query History does not result in an api exception.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai force-pushed the tai/fix-query-history-sort branch from 4c73365 to e2fe35f Compare December 2, 2020 18:54
@pull-request-size pull-request-size bot added size/XS and removed size/S labels Dec 2, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Dec 2, 2020

Codecov Report

Merging #11897 (02693a2) into master (1842c56) will decrease coverage by 3.49%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11897      +/-   ##
==========================================
- Coverage   67.64%   64.14%   -3.50%     
==========================================
  Files         927      461     -466     
  Lines       45014    28383   -16631     
  Branches     4308        0    -4308     
==========================================
- Hits        30448    18207   -12241     
+ Misses      14462    10176    -4286     
+ Partials      104        0     -104     
Flag Coverage Δ
cypress ?
javascript ?
python 64.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/profile/components/Security.tsx
...rontend/src/SqlLab/components/AceEditorWrapper.tsx
...frontend/src/dashboard/util/newEntitiesFromDrop.js
superset-frontend/src/explore/index.jsx
...set-frontend/src/views/CRUD/welcome/EmptyState.tsx
...frontend/src/dashboard/actions/dashboardFilters.js
...rset-frontend/src/profile/components/Favorites.tsx
...et-frontend/src/components/RefreshChartOverlay.tsx
...nd/src/explore/components/ExploreActionButtons.jsx
superset-frontend/src/explore/dateFilterUtils.ts
... and 454 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1842c56...e2fe35f. Read the comment docs.

@nytai nytai requested a review from dpgaspar December 2, 2020 20:54
@dpgaspar dpgaspar changed the title fix: sorting by user for Query History list view fix(query): sorting by user for Query History list view Dec 3, 2020
Copy link
Copy Markdown
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thks for the fix

@dpgaspar dpgaspar merged commit 8c063ef into apache:master Dec 3, 2020
@dpgaspar dpgaspar deleted the tai/fix-query-history-sort branch December 3, 2020 09:13
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.0.0 First shipped in 1.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants