feat: list view filters for Query History by nytai · Pull Request #11702 · apache/superset

nytai · 2020-11-14T01:24:23Z

SUMMARY

Add filters for Query History list view, including a date range filter.
upgrade antd and moment due to incompatible versions in the types for the DatePicker

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:

TEST PLAN

unit tested
manual testing:
- filter by Database
- filter by State
- filter by User
- filter by Time Range
- filter by query text

ADDITIONAL INFORMATION

codecov-io · 2020-11-14T01:37:15Z

Codecov Report

Merging #11702 (4475013) into master (3cd94d6) will decrease coverage by 3.82%.
The diff coverage is 85.49%.

@@            Coverage Diff             @@
##           master   #11702      +/-   ##
==========================================
- Coverage   67.56%   63.74%   -3.83%     
==========================================
  Files         918      924       +6     
  Lines       44755    44827      +72     
  Branches     4237     4253      +16     
==========================================
- Hits        30240    28575    -1665     
- Misses      14412    16075    +1663     
- Partials      103      177      +74

Flag	Coverage Δ
cypress	`?`
javascript	`63.03% <85.15%> (+0.14%)`	⬆️
python	`64.15% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...tend/src/views/CRUD/annotation/AnnotationModal.tsx	`66.66% <ø> (+0.52%)`	⬆️
...tend/src/components/ListView/Filters/DateRange.tsx	`52.17% <52.17%> (ø)`
...t-frontend/src/views/CRUD/data/query/QueryList.tsx	`72.11% <77.77%> (-0.62%)`	⬇️
...rontend/src/components/ListView/Filters/Search.tsx	`86.66% <86.66%> (ø)`
...frontend/src/components/ListView/Filters/index.tsx	`86.95% <86.95%> (ø)`
superset-frontend/src/components/ListView/utils.ts	`84.61% <92.30%> (+3.74%)`	⬆️
...t-frontend/src/components/ListView/Filters/Base.ts	`100.00% <100.00%> (ø)`
...rontend/src/components/ListView/Filters/Select.tsx	`97.56% <100.00%> (ø)`
superset-frontend/src/components/ListView/types.ts	`100.00% <100.00%> (ø)`
superset-frontend/src/views/CRUD/types.ts	`100.00% <100.00%> (ø)`
... and 183 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3cd94d6...4475013. Read the comment docs.

hughhhh · 2020-11-24T21:35:47Z

superset-frontend/src/views/CRUD/data/query/QueryList.tsx

  };

-  const initialSort = [{ id: 'changed_on', desc: true }];
+  const initialSort = [{ id: 'start_time', desc: true }];


nit: make this an enum initSortId at the top

I converted all the column names to an enum

eschutho · 2020-11-25T01:26:12Z

superset-frontend/src/components/ListView/utils.ts

+    .filter(f => {
+      if (typeof f.value === 'undefined') return false;
+      if (Array.isArray(f.value) && !f.value.length) return false;
+      return true;


how about

.filter(f => !((typeof f.value === 'undefined') || (Array.isArray(f.value) && !f.value.length)))

Do you actually find that more readable? These are two separate conditions for filtering out a value, it makes sense to keep them seperate imo

I do, since you're trying to see if it has a value on each type, but it's just preference. It mainly feels redundant to return an explicit boolean for a boolean conditional.
How about something like this for readability?

let hasValue = true; hasValue = !(typeof f.value === 'undefined'); hasValue = !(Array.isArray(f.value) && !f.value.length); return hasValue;

if that doesn't feel like an improvement, we can go with what you have. It's not anything major.

ok, updated. I have less of an issue with it now after the prettier formatting.

eschutho · 2020-11-25T01:30:21Z

superset-frontend/src/views/CRUD/data/query/QueryList.tsx

+        Header: t('Search by query text'),
+        id: 'sql',
+        input: 'search',
+        operator: 'ct',


second @hughhhh's comment on these strings, too.. they could prob all benefit from enums as well.

Created an enum FilterOperators with more descriptive names for each operator.

hughhhh · 2020-11-30T20:40:47Z

superset-frontend/src/components/ListView/types.ts

could we make this snakeCase?

converted to camelCase since that's the js standard

nytai · 2020-11-30T22:21:44Z

merging this before I get any more comments! 😃

superset-github-bot bot added the preset-io label Nov 14, 2020

pull-request-size bot added the size/XXL label Nov 14, 2020

nytai force-pushed the tai/query-history-filters branch from 56ad4aa to 6f2bf18 Compare November 14, 2020 01:27

nytai force-pushed the tai/query-history-filters branch from 849fbd5 to abcc71f Compare November 18, 2020 07:54

nytai linked an issue Nov 18, 2020 that may be closed by this pull request

SQL search query search string shouldn't be case sensititive #11585

Closed

nytai mentioned this pull request Nov 20, 2020

feat: use rison for list view filters stateful urls #11675

Merged

12 tasks

nytai force-pushed the tai/query-history-filters branch from b32d729 to 45565b9 Compare November 21, 2020 00:02

pull-request-size bot added size/XL and removed size/XXL labels Nov 21, 2020

nytai force-pushed the tai/query-history-filters branch from 343c17e to 346f825 Compare November 24, 2020 19:37

nytai changed the title ~~feat: list view filters to Query History~~ feat: list view filters for Query History Nov 24, 2020

nytai marked this pull request as ready for review November 24, 2020 19:47

hughhhh reviewed Nov 24, 2020

View reviewed changes

eschutho reviewed Nov 25, 2020

View reviewed changes

nytai force-pushed the tai/query-history-filters branch from 346f825 to d678727 Compare November 30, 2020 01:28

willbarrett approved these changes Nov 30, 2020

View reviewed changes

hughhhh reviewed Nov 30, 2020

View reviewed changes

nytai added 9 commits November 30, 2020 13:45

feat(queries): filters to Query History list view

b24686e

write specs

e3d7dba

fix snapshot

b8d51a3

fix dateRange null value

65ce06d

update snapshots

595c2ef

update types for listview filters

e7eefca

address review feedback

3d05e52

fix boolean statement

f9ec09c

make filter operators camelCase

4475013

nytai force-pushed the tai/query-history-filters branch from 765da29 to 4475013 Compare November 30, 2020 21:45

nytai merged commit 0117247 into apache:master Nov 30, 2020

nytai deleted the tai/query-history-filters branch November 30, 2020 22:21

nytai mentioned this pull request Dec 2, 2020

fix(query): sorting by user for Query History list view #11897

Merged

6 tasks

m-ajay mentioned this pull request Jun 24, 2023

[Snyk] Fix for 1 vulnerabilities m-ajay/superset#144

Open

m-ajay mentioned this pull request Jan 9, 2024

[Snyk] Security upgrade webpack from 4.46.0 to 5.1.1 m-ajay/superset#240

Open

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 First shipped in 1.0.0 labels Mar 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: list view filters for Query History #11702

feat: list view filters for Query History #11702
nytai merged 9 commits intoapache:masterfrom
preset-io:tai/query-history-filters

nytai commented Nov 14, 2020 •

edited

Loading

Uh oh!

codecov-io commented Nov 14, 2020 •

edited

Loading

Uh oh!

hughhhh Nov 24, 2020

Uh oh!

nytai Nov 30, 2020

Uh oh!

eschutho Nov 25, 2020

Uh oh!

nytai Nov 30, 2020

Uh oh!

eschutho Nov 30, 2020 •

edited

Loading

Uh oh!

nytai Nov 30, 2020

Uh oh!

eschutho Nov 25, 2020

Uh oh!

nytai Nov 30, 2020

Uh oh!

hughhhh Nov 30, 2020

Uh oh!

nytai Nov 30, 2020

Uh oh!

nytai commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

nytai commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

Uh oh!

codecov-io commented Nov 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

eschutho Nov 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nytai commented Nov 30, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

nytai commented Nov 14, 2020 •

edited

Loading

codecov-io commented Nov 14, 2020 •

edited

Loading

eschutho Nov 30, 2020 •

edited

Loading