Skip to content

Conversation

@dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented Sep 3, 2020

SUMMARY

Fixes: #10663

TEST PLAN

Create a saved query on SQLLab
go to saved queries and choose show record, the pages renders without problems

ADDITIONAL INFORMATION

@pull-request-size pull-request-size bot added size/M and removed size/XS labels Sep 3, 2020
@willbarrett willbarrett merged commit c1ff1c5 into apache:master Sep 4, 2020
@willbarrett willbarrett deleted the fix/show-saved-queries branch September 4, 2020 22:52
amitmiran137 pushed a commit to ofekisr/incubator-superset that referenced this pull request Sep 7, 2020
…boards_permissions

* upstream/master: (32 commits)
  docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796)
  Fix: Include RLS filters for cache keys (apache#10805)
  feat: filters for database list view (apache#10772)
  fix: MVC show saved query (apache#10781)
  added creator column and adjusted order columns (apache#10789)
  security: disallow uuid package on jinja2 (apache#10794)
  feat: CRUD REST API for saved queries (apache#10777)
  fix: disable domain sharding on explore view (apache#10787)
  fix: can not type `0.05` in `TextControl` (apache#10778)
  fix: pivot table timestamp grouping (apache#10774)
  fix: add validator information to email/slack alerts (apache#10762)
  More Label touchups (margins) (apache#10722)
  fix: dashboard extra filters (apache#10692)
  fix: re-installing local superset in cache image (apache#10766)
  feat: SIP-34 table list view for databases (apache#10705)
  refactor: convert DatasetList schema filter to use new distinct api (apache#10746)
  chore: removing fsevents dependency (apache#10751)
  Fix precommit hook for docs/installation.rst (apache#10759)
  feat(database): POST, PUT, DELETE API endpoints (apache#10741)
  docs: Update OAuth configuration in installation.rst (apache#10748)
  ...
@dpgaspar dpgaspar added the v0.38 label Sep 10, 2020
dpgaspar added a commit to preset-io/superset that referenced this pull request Sep 10, 2020
* fix: MVC show saved query

* remove it completely

* fix lint
villebro pushed a commit to preset-io/superset that referenced this pull request Sep 11, 2020
* fix: MVC show saved query

* remove it completely

* fix lint
villebro pushed a commit that referenced this pull request Sep 11, 2020
* fix: MVC show saved query

* remove it completely

* fix lint
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
* fix: MVC show saved query

* remove it completely

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 First shipped in 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v0.38 🚢 0.38.0 First shipped in 0.38.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"TypeError: 'str' object is not callable" on "Show record" in "Saved Queries"

4 participants