Skip to content

Conversation

@nytai
Copy link
Member

@nytai nytai commented Sep 3, 2020

SUMMARY

  • Filters for Database list view (Expose in SQL Lab, Allow Run Async, search on Database Name)
  • Empty state for ListView

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
Screen Shot 2020-09-02 at 6 22 28 PM
Screen Shot 2020-09-02 at 7 21 14 PM

TEST PLAN

-CI, enzyme tests, 👀

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI (behding ENABLE_REACT_CRUD_VIEWS config and SIP_34_DATABASE_UI feature flag)
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@nytai nytai force-pushed the tai/database-list-filters branch from 736ca54 to 2b5824a Compare September 3, 2020 02:24
@nytai nytai marked this pull request as ready for review September 3, 2020 21:49
Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nytai nytai merged commit 92f2353 into apache:master Sep 4, 2020
@nytai nytai deleted the tai/database-list-filters branch September 4, 2020 23:23
amitmiran137 pushed a commit to ofekisr/incubator-superset that referenced this pull request Sep 7, 2020
…boards_permissions

* upstream/master: (32 commits)
  docs: Add a note to contributing.md on reporting security vulnerabilities (apache#10796)
  Fix: Include RLS filters for cache keys (apache#10805)
  feat: filters for database list view (apache#10772)
  fix: MVC show saved query (apache#10781)
  added creator column and adjusted order columns (apache#10789)
  security: disallow uuid package on jinja2 (apache#10794)
  feat: CRUD REST API for saved queries (apache#10777)
  fix: disable domain sharding on explore view (apache#10787)
  fix: can not type `0.05` in `TextControl` (apache#10778)
  fix: pivot table timestamp grouping (apache#10774)
  fix: add validator information to email/slack alerts (apache#10762)
  More Label touchups (margins) (apache#10722)
  fix: dashboard extra filters (apache#10692)
  fix: re-installing local superset in cache image (apache#10766)
  feat: SIP-34 table list view for databases (apache#10705)
  refactor: convert DatasetList schema filter to use new distinct api (apache#10746)
  chore: removing fsevents dependency (apache#10751)
  Fix precommit hook for docs/installation.rst (apache#10759)
  feat(database): POST, PUT, DELETE API endpoints (apache#10741)
  docs: Update OAuth configuration in installation.rst (apache#10748)
  ...
auxten pushed a commit to auxten/incubator-superset that referenced this pull request Nov 20, 2020
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.38.0 First shipped in 0.38.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 0.38.0 First shipped in 0.38.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants