Skip to content

[SPARK-11961][DOC] Add docs of ChiSqSelector #9965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yinxusen wants to merge 2 commits into from
Closed

[SPARK-11961][DOC] Add docs of ChiSqSelector #9965

yinxusen wants to merge 2 commits into from

Conversation

@yinxusen
Copy link
Contributor

@yinxusen yinxusen commented Nov 25, 2015

@SparkQA
Copy link

SparkQA commented Nov 25, 2015

Test build #46678 has finished for PR 9965 at commit 4abd9d2.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaChiSqSelectorExample\n

@jkbradley
Copy link
Member

jkbradley commented Nov 25, 2015

reviewing now

jkbradley
jkbradley reviewed Nov 25, 2015
View reviewed changes
docs/ml-features.md Outdated
Copy link
Member

@jkbradley jkbradley Nov 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain what "clicked" means just to be clear

@jkbradley
Copy link
Member

jkbradley commented Nov 25, 2015

Some comments for the Scala example apply to Java too.

Those are initial comments. Unfortunately, there is an issue generating the docs currently, so I'm not quite done. We're looking into the doc gen problem.

@SparkQA
Copy link

SparkQA commented Nov 26, 2015

Test build #46743 has finished for PR 9965 at commit a77743f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaChiSqSelectorExample\n

@jkbradley
Copy link
Member

jkbradley commented Dec 1, 2015

LGTM. I'll test once more and then merge this.
Thank you!

@SparkQA
Copy link

SparkQA commented Dec 1, 2015

Test build #2136 has finished for PR 9965 at commit a77743f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaChiSqSelectorExample\n

@jkbradley
Copy link
Member

jkbradley commented Dec 1, 2015

Merging with master and branch-1.6

asfgit pushed a commit that referenced this pull request Dec 1, 2015
@yinxusen @jkbradley
[SPARK-11961][DOC] Add docs of ChiSqSelector
5647774 
https://issues.apache.org/jira/browse/SPARK-11961

Author: Xusen Yin <[email protected]>

Closes #9965 from yinxusen/SPARK-11961.

(cherry picked from commit e76431f)
Signed-off-by: Joseph K. Bradley <[email protected]>
@asfgit asfgit closed this in e76431f Dec 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yinxusen @SparkQA @jkbradley