[SPARK-11797][SQL] collect, first, and take should use encoders for serialization #9787
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
hmm, it looks to me that the only difference between this and Dataset.rdd is you add a copy here, should we remove Dataset.rdd?
Contributor
Author
There was a problem hiding this comment.
the main difference is that we are collecting the rows and then running the encoders to do conversions here.
Contributor
|
LGTM |
|
Test build #46141 has finished for PR 9787 at commit
|
|
Test build #46157 has finished for PR 9787 at commit
|
Contributor
|
retest this please. |
Contributor
Author
|
I'm going to optimistically merge this since most of the commits passed tests in the other pull request that includes this one. |
asfgit
pushed a commit
that referenced
this pull request
Nov 18, 2015
…erialization They were previously using Spark's default serializer for serialization. Author: Reynold Xin <[email protected]> Closes #9787 from rxin/SPARK-11797. (cherry picked from commit 91f4b6f) Signed-off-by: Reynold Xin <[email protected]>
|
Test build #46170 has finished for PR 9787 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were previously using Spark's default serializer for serialization.