Skip to content

Conversation

@rxin
Copy link
Contributor

@rxin rxin commented Nov 18, 2015

I also found a bug with self-joins returning incorrect results in the Dataset API. Two test cases attached and filed SPARK-11803.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about putting this method into ExpressionEncoder? I think Encoders is only used at java side as the lack of implicit magic.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then we can change the return type to ExpressionEncoder[T] and make the tests less verbose with asInstanseOf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if we want to use kryo in scala?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, this can't be done by implicit, I was wrong, nvm.

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46146 has finished for PR 9789 at commit 073f302.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class SerializeWithKryo(child: Expression) extends UnaryExpression\n * case class DeserializeWithKryo[T](child: Expression, tag: ClassTag[T]) extends UnaryExpression\n

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46179 has finished for PR 9789 at commit 765c7e6.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class SerializeWithKryo(child: Expression) extends UnaryExpression\n * case class DeserializeWithKryo[T](child: Expression, tag: ClassTag[T]) extends UnaryExpression\n * public final class UTF8String implements Comparable<UTF8String>, Externalizable, KryoSerializable\n

asfgit pushed a commit that referenced this pull request Nov 18, 2015
I also found a bug with self-joins returning incorrect results in the Dataset API. Two test cases attached and filed SPARK-11803.

Author: Reynold Xin <[email protected]>

Closes #9789 from rxin/SPARK-11802.

(cherry picked from commit 5e2b444)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 5e2b444 Nov 18, 2015
@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46175 has finished for PR 9789 at commit 7e39a17.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * case class SerializeWithKryo(child: Expression) extends UnaryExpression\n * case class DeserializeWithKryo[T](child: Expression, tag: ClassTag[T]) extends UnaryExpression\n * public final class UTF8String implements Comparable<UTF8String>, Externalizable, KryoSerializable\n

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants