-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-11728] Replace example code in ml-ensembles.md using include_example #9716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #45929 has finished for PR 9716 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is different from current example code in user guide, where we use sqlContext.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt"). Please find other places and switch to using "libsvm" data source instead.
|
LGTM except one issue commented inline. Please keep the example code the same while moving them around. It is easier for review. |
|
Fixed, sorry for the carelessness. |
|
Test build #46164 has finished for PR 9716 at commit
|
|
Test build #46162 has finished for PR 9716 at commit
|
…xample JIRA issue https://issues.apache.org/jira/browse/SPARK-11728. The ml-ensembles.md file contains `OneVsRestExample`. Instead of writing new code files of two `OneVsRestExample`s, I use two existing files in the examples directory, they are `OneVsRestExample.scala` and `JavaOneVsRestExample.scala`. Author: Xusen Yin <[email protected]> Closes #9716 from yinxusen/SPARK-11728. (cherry picked from commit 9154f89) Signed-off-by: Xiangrui Meng <[email protected]>
|
Merged into master and branch-1.6. Thanks! |
JIRA issue https://issues.apache.org/jira/browse/SPARK-11728.
The ml-ensembles.md file contains
OneVsRestExample. Instead of writing new code files of twoOneVsRestExamples, I use two existing files in the examples directory, they areOneVsRestExample.scalaandJavaOneVsRestExample.scala.