Skip to content

Conversation

@yinxusen
Copy link
Contributor

JIRA issue https://issues.apache.org/jira/browse/SPARK-11728.

The ml-ensembles.md file contains OneVsRestExample. Instead of writing new code files of two OneVsRestExamples, I use two existing files in the examples directory, they are OneVsRestExample.scala and JavaOneVsRestExample.scala.

@SparkQA
Copy link

SparkQA commented Nov 14, 2015

Test build #45929 has finished for PR 9716 at commit 9ba1d4a.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaGradientBoostedTreeClassifierExample\n * public class JavaGradientBoostedTreeRegressorExample\n * public class JavaRandomForestClassifierExample\n * public class JavaRandomForestRegressorExample\n

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is different from current example code in user guide, where we use sqlContext.read.format("libsvm").load("data/mllib/sample_libsvm_data.txt"). Please find other places and switch to using "libsvm" data source instead.

@mengxr
Copy link
Contributor

mengxr commented Nov 17, 2015

LGTM except one issue commented inline. Please keep the example code the same while moving them around. It is easier for review.

@yinxusen
Copy link
Contributor Author

Fixed, sorry for the carelessness.

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46164 has finished for PR 9716 at commit 4d9cffb.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaGradientBoostedTreeClassifierExample\n * public class JavaGradientBoostedTreeRegressorExample\n * public class JavaRandomForestClassifierExample\n * public class JavaRandomForestRegressorExample\n

@SparkQA
Copy link

SparkQA commented Nov 18, 2015

Test build #46162 has finished for PR 9716 at commit 2ed613a.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):\n * public class JavaGradientBoostedTreeClassifierExample\n * public class JavaGradientBoostedTreeRegressorExample\n * public class JavaRandomForestClassifierExample\n * public class JavaRandomForestRegressorExample\n

asfgit pushed a commit that referenced this pull request Nov 18, 2015
…xample

JIRA issue https://issues.apache.org/jira/browse/SPARK-11728.

The ml-ensembles.md file contains `OneVsRestExample`. Instead of writing new code files of two `OneVsRestExample`s, I use two existing files in the examples directory, they are `OneVsRestExample.scala` and `JavaOneVsRestExample.scala`.

Author: Xusen Yin <[email protected]>

Closes #9716 from yinxusen/SPARK-11728.

(cherry picked from commit 9154f89)
Signed-off-by: Xiangrui Meng <[email protected]>
@mengxr
Copy link
Contributor

mengxr commented Nov 18, 2015

Merged into master and branch-1.6. Thanks!

@asfgit asfgit closed this in 9154f89 Nov 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants