Skip to content

[SPARK-9388] [yarn] Make executor info log messages easier to read. #7706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vanzin wants to merge 3 commits into from
Closed

[SPARK-9388] [yarn] Make executor info log messages easier to read. #7706

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5bcd7a0
[SPARK-9388] [yarn] Make executor info log messages easier to read.
Jul 27, 2015
3c5fb6a
YARN not Yarn.
Jul 27, 2015
028b990
Single log statement.
Jul 28, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,7 @@ private[spark] class Client(
amContainer.setCommands(printableCommands)

logDebug("===============================================================================")
logDebug("Yarn AM launch context:")
logDebug("YARN AM launch context:")
logDebug(s" user class: ${Option(args.userClass).getOrElse("N/A")}")
logDebug(" env:")
launchEnv.foreach { case (k, v) => logDebug(s" $k -> $v") }
Expand Down
11 changes: 8 additions & 3 deletions yarn/src/main/scala/org/apache/spark/deploy/yarn/ExecutorRunnable.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,10 +86,15 @@ class ExecutorRunnable(
val commands = prepareCommand(masterAddress, slaveId, hostname, executorMemory, executorCores,
appId, localResources)

logInfo(s"Setting up executor with environment: $env")
logInfo("Setting up executor with commands: " + commands)
ctx.setCommands(commands)
logInfo("===============================================================================")
logInfo("YARN executor launch context:")
Copy link
Contributor

@rxin rxin Jul 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to combine them into a single logging statement to avoid interleaved logging messages?

logInfo(" env:")
env.foreach { case (k, v) => logInfo(s" $k -> $v") }
logInfo(" command:")
logInfo(s" ${commands.mkString(" ")}")
logInfo("===============================================================================")

ctx.setCommands(commands)
ctx.setApplicationACLs(YarnSparkHadoopUtil.getApplicationAclsForYarn(securityMgr))

// If external shuffle service is enabled, register with the Yarn shuffle service already
Expand Down