-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-9388] [yarn] Make executor info log messages easier to read. #7706
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: capitalize all of YARN
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be better to combine them into a single logging statement to avoid interleaved logging messages?
|
Test build #38610 has finished for PR 7706 at commit
|
|
Looks OK to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit indentation to match below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually the indentation is in the generated string (yes, a little confusing, but this way it aligns properly).
|
looks good. minor indentation if you want to fix. |
|
LGTM retest this please |
|
Test build #38741 has finished for PR 7706 at commit
|
|
Failure in unrelated part of the code. Let's try one more time. |
|
Jenkins retest this please. |
|
Test build #38773 has finished for PR 7706 at commit
|
|
Test build #141 has finished for PR 7706 at commit
|
|
Merged to master. |
No description provided.