Skip to content

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Jul 27, 2015

No description provided.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: capitalize all of YARN

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be better to combine them into a single logging statement to avoid interleaved logging messages?

@SparkQA
Copy link

SparkQA commented Jul 28, 2015

Test build #38610 has finished for PR 7706 at commit 028b990.

  • This patch fails PySpark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@srowen
Copy link
Member

srowen commented Jul 28, 2015

Looks OK to me

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit indentation to match below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the indentation is in the generated string (yes, a little confusing, but this way it aligns properly).

@tgravescs
Copy link
Contributor

looks good. minor indentation if you want to fix.

@andrewor14
Copy link
Contributor

LGTM retest this please

@SparkQA
Copy link

SparkQA commented Jul 28, 2015

Test build #38741 has finished for PR 7706 at commit 028b990.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 28, 2015

Failure in unrelated part of the code. Let's try one more time.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 28, 2015

Jenkins retest this please.

@SparkQA
Copy link

SparkQA commented Jul 29, 2015

Test build #38773 has finished for PR 7706 at commit 028b990.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Jul 29, 2015

Test build #141 has finished for PR 7706 at commit 028b990.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@vanzin
Copy link
Contributor Author

vanzin commented Jul 30, 2015

Merged to master.

@asfgit asfgit closed this in ab78b1d Jul 30, 2015
@vanzin vanzin deleted the SPARK-9388 branch July 30, 2015 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants