[SPARK-54972][SQL] Improve NOT IN subqueries with non-nullable columns #53733
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JIRA Issue Information=== Improvement SPARK-54972 === This comment was automatically generated by GitHub Actions |
peter-toth
commented
Jan 8, 2026
| // positive not in subquery case | ||
| var joinExec = assertJoin(( | ||
| "select * from testData where key not in (select a from testData2)", | ||
| "select * from testData where key not in (select b from testData3)", |
Contributor
Author
There was a problem hiding this comment.
testData2 columns are not nullable, but we need a nullable column to keep this test valid (assert(joinExec.asInstanceOf[BroadcastHashJoinExec].isNullAwareAntiJoin)).
Contributor
Author
|
cc @cloud-fan , @dongjoon-hyun |
peter-toth
force-pushed
the
SPARK-54972-improve-not-in-with-non-nullables
branch
from
11e8cf1 to
6961295
Compare
dongjoon-hyun
approved these changes
Jan 9, 2026
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM.
Thank you for pinging me, @peter-toth . The PR itself looks reasonable to me. Could you simply re-trigger the CI failure because it looks irrelevant to this?
- SPARK-47148: AQE should avoid to submit shuffle job on cancellation *** FAILED *** (6 seconds, 125 milliseconds)
Contributor
Author
|
Thanks @dongjoon-hyun for the review. Merged to |
Yicong-Huang
pushed a commit
to Yicong-Huang/spark
that referenced
this pull request
Jan 9, 2026
### What changes were proposed in this pull request? Run `NullPropagation` after NOT IN subquery rewrite. ### Why are the changes needed? NOT IN subqueries like `SELECT * FROM t1 WHERE c NOT IN (SELECT c FROM t2)` are rewritten as left anti join `t1.c = t2.c` with additional `OR IsNull(t1.c = t2.c)` conditions which prevents equi join implementations to be used so those joins end up as `BroadcastNestedLoopJoin`. When we know the columns can't be null, we can either drop those additional conditions during subquery rewrite or call `NullPropagation` after the rewrite to simplify them to `false`. This PR contains the latter. Please note that apache#29104 already optmized the single column NOT IN subqueries from `BroadcastNestedLoopJoin` to "null aware" `BroadcastHashJoin` very well, but when the columns are not nullable we can optimize multi column cases as well and the join don't need to be "null aware". ### Does this PR introduce _any_ user-facing change? Yes, performance improvement. ### How was this patch tested? A new UTs was added and some exsisting tests were adjusted to keep their validity. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#53733 from peter-toth/SPARK-54972-improve-not-in-with-non-nullables. Authored-by: Peter Toth <[email protected]> Signed-off-by: Peter Toth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Run
NullPropagationafter NOT IN subquery rewrite.Why are the changes needed?
NOT IN subqueries like
SELECT * FROM t1 WHERE c NOT IN (SELECT c FROM t2)are rewritten as left anti joint1.c = t2.cwith additionalOR IsNull(t1.c = t2.c)conditions which prevents equi join implementations to be used so those joins end up asBroadcastNestedLoopJoin. When we know the columns can't be null, we can either drop those additional conditions during subquery rewrite or callNullPropagationafter the rewrite to simplify them tofalse. This PR contains the latter.Please note that #29104 already optmized the single column NOT IN subqueries from
BroadcastNestedLoopJointo "null aware"BroadcastHashJoinvery well, but when the columns are not nullable we can optimize multi column cases as well and the join don't need to be "null aware".Does this PR introduce any user-facing change?
Yes, performance improvement.
How was this patch tested?
A new UTs was added and some exsisting tests were adjusted to keep their validity.
Was this patch authored or co-authored using generative AI tooling?
No.