[SPARK-53960][SQL] Let approx_top_k_accumulate/combine/estimate handle NULLs #52673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhuang-db
commented
Oct 20, 2025
| } | ||
| } | ||
|
|
||
| def updateSketchBuffer( |
Contributor
Author
There was a problem hiding this comment.
Unused functions as update and evaluation are handled by ApproxTopKAggregateBuffer, not on ItemsSketch anymore.
| } | ||
|
|
||
| test("SPARK-53960: combine and estimate count NULL values") { | ||
| sql( |
Member
There was a problem hiding this comment.
nit: let's add withView before each test case
Contributor
Author
There was a problem hiding this comment.
Thanks. Added to all tests with views.
| checkAnswer(est, Row(Seq(Row(null, 4), Row("b", 3)))) | ||
| } | ||
|
|
||
| test("SPARK-53960: combine with a sketch of all nulls") { |
Member
There was a problem hiding this comment.
nit: let's test combining two sketches of all nulls
Contributor
Author
There was a problem hiding this comment.
gengliangwang
approved these changes
Oct 21, 2025
Member
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
LGTM except minor comments
Member
|
Thanks, merging to master |
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…e NULLs ### What changes were proposed in this pull request? As a follow-up of apache#52655, add NULL handling in approx_top_k_accumulate/estimate/combine. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? New unit tests on null handling for accumulate, combine and estimate. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#52673 from yhuang-db/accumulate_estimate_count_null. Authored-by: yhuang-db <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As a follow-up of #52655, add NULL handling in approx_top_k_accumulate/estimate/combine.
Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
New unit tests on null handling for accumulate, combine and estimate.
Was this patch authored or co-authored using generative AI tooling?
No