[SPARK-53947][SQL] Count null in approx_top_k #52655
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
| override def update(buffer: ItemsSketch[Any], input: InternalRow): ItemsSketch[Any] = | ||
| ApproxTopK.updateSketchBuffer(expr, buffer, input) | ||
| override def update(buffer: ApproxTopKAggregateBuffer[Any], input: InternalRow): | ||
| ApproxTopKAggregateBuffer[Any] = |
| override def merge( | ||
| buffer: ApproxTopKAggregateBuffer[Any], | ||
| input: ApproxTopKAggregateBuffer[Any]): | ||
| ApproxTopKAggregateBuffer[Any] = |
| } | ||
|
|
||
| test("SPARK-52515: does not count NULL values") { | ||
| test("SPARK-52515: count NULL values") { |
| checkAnswer(res, Row(Seq(Row("b", 3), Row("a", 2)))) | ||
| } | ||
|
|
||
| test("SPARK-52515: null is the last in top k") { |
gengliangwang
approved these changes
Oct 20, 2025
Member
|
Thanks, merging to master |
gengliangwang
pushed a commit
that referenced
this pull request
Oct 21, 2025
…e NULLs ### What changes were proposed in this pull request? As a follow-up of #52655, add NULL handling in approx_top_k_accumulate/estimate/combine. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? New unit tests on null handling for accumulate, combine and estimate. ### Was this patch authored or co-authored using generative AI tooling? No Closes #52673 from yhuang-db/accumulate_estimate_count_null. Authored-by: yhuang-db <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR proposes to add a nullCounter associated with the Frequent Item Sketch in `approx_top_k` aggregation, so that now the function will return null item and null count if NULL value is among the top_k frequent items. ### Why are the changes needed? NULL value could be meaningful in some use cases and users might want to include NULL in the approx_top_k output. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New unit tests on handling null values. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52655 from yhuang-db/approx_top_k_count_null. Authored-by: yhuang-db <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
…e NULLs ### What changes were proposed in this pull request? As a follow-up of apache#52655, add NULL handling in approx_top_k_accumulate/estimate/combine. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? New unit tests on null handling for accumulate, combine and estimate. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#52673 from yhuang-db/accumulate_estimate_count_null. Authored-by: yhuang-db <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to add a nullCounter associated with the Frequent Item Sketch in
approx_top_kaggregation, so that now the function will return null item and null count if NULL value is among the top_k frequent items.Why are the changes needed?
NULL value could be meaningful in some use cases and users might want to include NULL in the approx_top_k output.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit tests on handling null values.
Was this patch authored or co-authored using generative AI tooling?
No.