Skip to content

[SPARK-6608] [SQL] Makes DataFrame.rdd a lazy val #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liancheng wants to merge 2 commits into from
Closed

[SPARK-6608] [SQL] Makes DataFrame.rdd a lazy val #5265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7f37d21
Makes DataFrame.rdd a lazy val
liancheng Mar 30, 2015
7500968
Updates javadoc
liancheng Mar 31, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/DataFrame.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -941,10 +941,10 @@ class DataFrame private[sql](
/////////////////////////////////////////////////////////////////////////////

/**
* Returns the content of the [[DataFrame]] as an [[RDD]] of [[Row]]s.
* Represents the content of the [[DataFrame]] as an [[RDD]] of [[Row]]s.
Copy link
Contributor

@rxin rxin Mar 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you update the doc to say that the RDD is memoized, i.e. once called, even if you change the spark sql configuration, it won't change the plan anymore?

Copy link
Contributor Author

@liancheng liancheng Mar 31, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, that's a good point.

* @group rdd
*/
def rdd: RDD[Row] = {
lazy val rdd: RDD[Row] = {
// use a local variable to make sure the map closure doesn't capture the whole DataFrame
val schema = this.schema
queryExecution.executedPlan.execute().map(ScalaReflection.convertRowToScala(_, schema))
Expand Down