-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-6608] [SQL] Makes DataFrame.rdd a lazy val #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rxin Is there a good reason that makes |
|
Test build #29399 has started for PR 5265 at commit |
|
+1 for this, since for example the caching logic from ml package doesn't work properly. |
|
Test build #29399 has finished for PR 5265 at commit
|
|
Test PASSed. |
|
@petro-rudenko Oops, that's a good catch! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you update the doc to say that the RDD is memoized, i.e. once called, even if you change the spark sql configuration, it won't change the plan anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a good point.
|
Test build #29484 has started for PR 5265 at commit |
|
Test build #29484 has finished for PR 5265 at commit
|
|
Test PASSed. |
|
LGTM. |
|
Merged to master. Thanks for the review! |
Before 1.3.0,
SchemaRDD.idworks as a unique identifier of eachSchemaRDD. In 1.3.0, unlikeSchemaRDD,DataFrameis no longer an RDD, andDataFrame.rddis actually a function which always returns a new RDD instance. MakingDataFrame.rdda lazy val should bring the unique identifier back.