Skip to content

[SPARK-52933][K8S] Verify if the executor cpu request exceeds limit #51678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 3 commits into from
Closed

[SPARK-52933][K8S] Verify if the executor cpu request exceeds limit #51678

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
df03689
[SPARK-52933][K8S] Verify if the executor cpu request exceeds limit
dongjoon-hyun Jul 27, 2025
202dce7
indentation
dongjoon-hyun Jul 27, 2025
34c1d39
Address comments
dongjoon-hyun Jul 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ...s/core/src/main/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStep.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,6 +226,10 @@ private[spark] class BasicExecutorFeatureStep(
val containerWithLimitCores = if (isDefaultProfile) {
executorLimitCores.map { limitCores =>
val executorCpuLimitQuantity = new Quantity(limitCores)
if (executorCpuLimitQuantity.compareTo(executorCpuQuantity) < 0) {
throw new SparkException(
"The executor cpu request should be less than or equal to cpu limit")

@LuciferYang LuciferYang Jul 28, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Should the request value and limit value be included in the error message?

}
new ContainerBuilder(executorContainerWithConfVolume)
.editResources()
.addToLimits("cpu", executorCpuLimitQuantity)
Expand Down
12 changes: 12 additions & 0 deletions ...e/src/test/scala/org/apache/spark/deploy/k8s/features/BasicExecutorFeatureStepSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,18 @@ class BasicExecutorFeatureStepSuite extends SparkFunSuite with BeforeAndAfter {
assert(error.contains("You must specify an amount for gpu"))
}

test("SPARK-52933: Verify if the executor cpu request exceeds limit") {
baseConf.set(KUBERNETES_EXECUTOR_REQUEST_CORES, "2")
baseConf.set(KUBERNETES_EXECUTOR_LIMIT_CORES, "1")
val error = intercept[SparkException] {
initDefaultProfile(baseConf)
val step = new BasicExecutorFeatureStep(newExecutorConf(), new SecurityManager(baseConf),
defaultProfile)
val executor = step.configurePod(SparkPod.initialPod())
}.getMessage()
assert(error.contains("The executor cpu request should be less than or equal to cpu limit"))
}

test("basic executor pod with resources") {
val fpgaResourceID = new ResourceID(SPARK_EXECUTOR_PREFIX, FPGA)
val gpuExecutorResourceID = new ResourceID(SPARK_EXECUTOR_PREFIX, GPU)
Expand Down