[SPARK-52933][K8S] Verify if the executor cpu request exceeds limit #51678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Could you review this when you have some time, @peter-toth ? |
Member
Author
|
Could you review this PR when you have some time, @HyukjinKwon ? |
LuciferYang
approved these changes
Jul 28, 2025
LuciferYang
reviewed
Jul 28, 2025
| val executorCpuLimitQuantity = new Quantity(limitCores) | ||
| if (executorCpuLimitQuantity.compareTo(executorCpuQuantity) < 0) { | ||
| throw new SparkException( | ||
| "The executor cpu request should be less than or equal to cpu limit") |
Contributor
There was a problem hiding this comment.
nit: Should the request value and limit value be included in the error message?
HyukjinKwon
approved these changes
Jul 28, 2025
Member
Author
|
Thank you, @LuciferYang and @HyukjinKwon . |
LuciferYang
approved these changes
Jul 28, 2025
Member
Author
|
All comments are addressed and I verified the test result manually because the last commit changes only the exception message string. Merged to master for Apache Spark 4.1.0. |
|
Thanks a lot for pushing this PR! @dongjoon-hyun |
dongjoon-hyun
added a commit
to apache/spark-kubernetes-operator
that referenced
this pull request
Oct 2, 2025
### What changes were proposed in this pull request? This PR aims to upgrade Spark to `4.1.0-preview2` for `4.0.1`. ### Why are the changes needed? Since Apache Spark 4.1.0 is planned next month, we had better prepare to use new features via using `4.1.0-preview2` (September) and `4.1.0-preview2 (October)` gradually. - apache/spark#51678 - apache/spark#51522 - apache/spark#50925 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #364 from dongjoon-hyun/SPARK-53787. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
shubhluck
pushed a commit
to acceldata-io/spark3
that referenced
this pull request
Dec 11, 2025
### What changes were proposed in this pull request? This PR aims to verify if the executor pod's cpu request exceeds cpu limit or not in order to make it fail-fast. ### Why are the changes needed? Since Spark creates many executor pods, we had better do fail-fast on the invalid settings before submitting invalid pod spec to K8s cluster. It wastes lots of K8s resources. Note that newly added validation check only happens when `spark.kubernetes.executor.limit.cores` is given explicitly. ### Does this PR introduce _any_ user-facing change? No behavior change eventually because the existing misconfigured `spark.kubernetes.executor.limit.cores` means Spark driver cannot get any executor pods and the job will hang or fail eventually. ### How was this patch tested? Pass the CIs with the newly added test case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#51678 from dongjoon-hyun/SPARK-52933. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 4dc3f0f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to verify if the executor pod's cpu request exceeds cpu limit or not in order to make it fail-fast.
Why are the changes needed?
Since Spark creates many executor pods, we had better do fail-fast on the invalid settings before submitting invalid pod spec to K8s cluster. It wastes lots of K8s resources.
Note that newly added validation check only happens when
spark.kubernetes.executor.limit.coresis given explicitly.Does this PR introduce any user-facing change?
No behavior change eventually because the existing misconfigured
spark.kubernetes.executor.limit.coresmeans Spark driver cannot get any executor pods and the job will hang or fail eventually.How was this patch tested?
Pass the CIs with the newly added test case.
Was this patch authored or co-authored using generative AI tooling?
No.