[SPARK-47481][INFRA][3.4] Pin matplotlib<3.3.0 to fix Python linter failure
#45608
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@dongjoon-hyun Although there are still I am still continuing to research this issue. |
panbingkun
changed the title
matplotlib<3.3.0
dongjoon-hyun
approved these changes
Mar 20, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @panbingkun , of course.
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
matplotlib<3.3.0 to fix Python linter failure
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 20, 2024
… failure ### What changes were proposed in this pull request? The pr aims to fix `python linter issue` on branch-3.4 through pinning `matplotlib<3.3.0` ### Why are the changes needed? - Through this PR #45600, we found that the version of `matplotlib` in our Docker image was `3.8.2`, which clearly did not meet the original requirements for `branch-3.4`. https://github.com/panbingkun/spark/actions/runs/8354370179/job/22869580038 <img width="1072" alt="image" src="https://github.com/apache/spark/assets/15246973/dd425bfb-ce5f-4a99-a487-a462d6ebbbb9"> https://github.com/apache/spark/blob/branch-3.4/dev/requirements.txt#L12 <img width="973" alt="image" src="https://github.com/apache/spark/assets/15246973/70485648-b886-4218-bb21-c41a85d5eecf"> - Fix as follows: <img width="989" alt="image" src="https://github.com/apache/spark/assets/15246973/db31d8fb-0b6c-4925-95e1-0ca0247bb9f5"> ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45608 from panbingkun/branch_3.4_pin_matplotlib. Authored-by: panbingkun <panbingkun@baidu.com> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
Member
|
Merged to branch-3.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to fix
python linter issueon branch-3.4 through pinningmatplotlib<3.3.0Why are the changes needed?
Through this PR [Don't Review] Only for list python packages for branch-3.4 #45600, we found that the version of
matplotlibin our Docker image was3.8.2, which clearly did not meet the original requirements forbranch-3.4.https://github.com/panbingkun/spark/actions/runs/8354370179/job/22869580038
https://github.com/apache/spark/blob/branch-3.4/dev/requirements.txt#L12
Fix as follows:
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.