Skip to content

Conversation

@panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Mar 17, 2024

What changes were proposed in this pull request?

The pr aims to fix python linter issue on branch-3.5 through pinning matplotlib==3.7.2

Why are the changes needed?

Fix python linter issue on branch-3.5.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Mar 17, 2024
@panbingkun panbingkun changed the title [ONLY TEST] Branch 3.5 scheduled job [ONLY TEST] Branch 3.5 CI Mar 18, 2024
@dongjoon-hyun
Copy link
Member

Hi, @panbingkun . Shall we rebase this to the master and merge to recover branch-3.5?

@panbingkun
Copy link
Contributor Author

Hi, @panbingkun . Shall we rebase this to the master and merge to recover branch-3.5?

Okay

@panbingkun
Copy link
Contributor Author

Hi, @panbingkun . Shall we rebase this to the master and merge to recover branch-3.5?

Okay

Done.

@panbingkun panbingkun changed the title [ONLY TEST] Branch 3.5 CI [SPARK-47481][3.5] Fix Python linter Mar 20, 2024
@panbingkun
Copy link
Contributor Author

@dongjoon-hyun
The related changes to branch-3.4 are here: #45608.

@panbingkun panbingkun marked this pull request as ready for review March 20, 2024 14:00
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-47481][3.5] Fix Python linter [SPARK-47481][INFRA][3.5] Fix Python linter Mar 20, 2024
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

dongjoon-hyun pushed a commit that referenced this pull request Mar 20, 2024
### What changes were proposed in this pull request?
The pr aims to fix `python linter issue` on `branch-3.5` through pinning `matplotlib==3.7.2`

### Why are the changes needed?
Fix `python linter issue` on `branch-3.5`.

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

### Was this patch authored or co-authored using generative AI tooling?
No.

Closes #45550 from panbingkun/branch-3.5_scheduled_job.

Authored-by: panbingkun <panbingkun@baidu.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
@dongjoon-hyun
Copy link
Member

Merged to branch-3.5. Thank you, @panbingkun .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants