Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jan 11, 2024

What changes were proposed in this pull request?

This is a follow-up of #44673 to fix the test case by adding a persistent DriverInfo.

Why are the changes needed?

To make the test case fail without the main patch. Previously, this is missed. So, the test case succeeds without the main patch.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the CORE label Jan 11, 2024
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang .
Merged to master.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-46664-2 branch January 11, 2024 16:34
szehon-ho pushed a commit to szehon-ho/spark that referenced this pull request Feb 7, 2024
### What changes were proposed in this pull request?

This is a follow-up of apache#44673 to fix the test case by adding a persistent `DriverInfo`.

### Why are the changes needed?

To make the test case fail without the main patch. Previously, this is missed. So, the test case succeeds without the main patch.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass the CIs.

### Was this patch authored or co-authored using generative AI tooling?

No.

Closes apache#44693 from dongjoon-hyun/SPARK-46664-2.

Authored-by: Dongjoon Hyun <[email protected]>
Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants