[SPARK-46664][CORE] Improve Master to recover quickly in case of zero workers and apps
#44673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ro workers and apps
dongjoon-hyun
force-pushed
the
SPARK-46664
branch
from
de432ba to
8af7f47
Compare
mridulm
reviewed
Jan 10, 2024
core/src/main/scala/org/apache/spark/deploy/master/Master.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
Thank you for review, @mridulm . The PR is updated accordingly. |
mridulm
approved these changes
Jan 10, 2024
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
Looks good to me, thanks for fixing this @dongjoon-hyun !
Member
Author
|
Thank you, @mridulm . |
dongjoon-hyun
added a commit
that referenced
this pull request
Jan 11, 2024
### What changes were proposed in this pull request? This is a follow-up of #44673 to fix the test case by adding a persistent `DriverInfo`. ### Why are the changes needed? To make the test case fail without the main patch. Previously, this is missed. So, the test case succeeds without the main patch. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44693 from dongjoon-hyun/SPARK-46664-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…ro workers and apps ### What changes were proposed in this pull request? This PR aims to improve `Master` to recover quickly in case of zero workers and apps. ### Why are the changes needed? This case happens on the initial cluster creation or during cluster restarting procedure. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs with the newly added test case. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44673 from dongjoon-hyun/SPARK-46664. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
### What changes were proposed in this pull request? This is a follow-up of apache#44673 to fix the test case by adding a persistent `DriverInfo`. ### Why are the changes needed? To make the test case fail without the main patch. Previously, this is missed. So, the test case succeeds without the main patch. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44693 from dongjoon-hyun/SPARK-46664-2. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to improve
Masterto recover quickly in case of zero workers and apps.Why are the changes needed?
This case happens on the initial cluster creation or during cluster restarting procedure.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass the CIs with the newly added test case.
Was this patch authored or co-authored using generative AI tooling?
No.