Skip to content

[SPARK-46652][SQL][TESTS] Remove Snappy from TPCDSQueryBenchmark benchmark case name #44657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dongjoon-hyun wants to merge 3 commits into from
Closed

[SPARK-46652][SQL][TESTS] Remove Snappy from TPCDSQueryBenchmark benchmark case name #44657

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a2b6042
[SPARK-46652][SQL][TESTS] Remove `Snappy` from `TPCDSQueryBenchmark` …
dongjoon-hyun Jan 10, 2024
9977a60
Remove unused import
dongjoon-hyun Jan 10, 2024
c4b14a0
Update benchmark results
dongjoon-hyun Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/benchmark/TPCDSQueryBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ import org.apache.spark.sql.catalyst.plans.logical.SubqueryAlias
import org.apache.spark.sql.catalyst.util._
import org.apache.spark.sql.catalyst.util.DateTimeConstants.NANOS_PER_SECOND
import org.apache.spark.sql.execution.datasources.LogicalRelation
import org.apache.spark.sql.execution.datasources.parquet.ParquetCompressionCodec
import org.apache.spark.sql.internal.SQLConf
import org.apache.spark.sql.types.StructType

Expand All @@ -52,7 +51,6 @@ object TPCDSQueryBenchmark extends SqlBasedBenchmark with Logging {
val conf = new SparkConf()
.setMaster(System.getProperty("spark.sql.test.master", "local[1]"))
.setAppName("test-sql-context")
.set("spark.sql.parquet.compression.codec", ParquetCompressionCodec.SNAPPY.lowerCaseName())
.set("spark.sql.shuffle.partitions", System.getProperty("spark.sql.shuffle.partitions", "4"))
.set("spark.driver.memory", "3g")
.set("spark.executor.memory", "3g")
Expand Down Expand Up @@ -108,7 +106,7 @@ object TPCDSQueryBenchmark extends SqlBasedBenchmark with Logging {
case _ =>
}
val numRows = queryRelations.map(tableSizes.getOrElse(_, 0L)).sum
val benchmark = new Benchmark(s"TPCDS Snappy", numRows, 2, output = output)
val benchmark = new Benchmark("TPCDS", numRows, 2, output = output)
benchmark.addCase(s"$name$nameSuffix") { _ =>
spark.sql(queryString).noop()
}
Expand Down