[SPARK-46652][SQL][TESTS] Remove Snappy from TPCDSQueryBenchmark benchmark case name
#44657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…benchmark case name
Member
Author
|
cc @yaooqinn |
yaooqinn
approved these changes
Jan 10, 2024
HyukjinKwon
approved these changes
Jan 10, 2024
LuciferYang
approved these changes
Jan 10, 2024
Member
Author
|
Thank you all! Merged to master. |
szehon-ho
pushed a commit
to szehon-ho/spark
that referenced
this pull request
Feb 7, 2024
…benchmark case name This PR aims to remove a hard-coded compression codec name from `benchmark case name` in `TPCDSQueryBenchmark`. `GenTPCDSData` can generate dataset with the other compression codecs than `snappy`. So, we had better remove the hard-coded `Snappy` because it's misleading. ``` $ JDK_JAVA_OPTIONS='spark.sql.parquet.compression.codec=zstd' \ build/sbt "sql/Test/runMain org.apache.spark.sql.GenTPCDSData --dsdgenDir /Users/dongjoon/DATA/tpcds-kit/tools --location /Users/dongjoon/DATA/tpcds-sf-1-zstd --scaleFactor 1 --numPartitions 1" ``` No. Manual test. No. Closes apache#44657 from dongjoon-hyun/SPARK-46652. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to remove a hard-coded compression codec name from
benchmark case nameinTPCDSQueryBenchmark.Why are the changes needed?
GenTPCDSDatacan generate dataset with the other compression codecs thansnappy. So, we had better remove the hard-codedSnappybecause it's misleading.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manual test.
Was this patch authored or co-authored using generative AI tooling?
No.