Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 4, 2024

What changes were proposed in this pull request?

This PR is a followup of #44519 that fixes a mistake of separating the paths. It should use Files.pathSeparator.

Why are the changes needed?

It works with testing mode, but it doesn't work with production mode otherwise.

Does this PR introduce any user-facing change?

No, because the main change has not been released.

How was this patch tested?

Manually as described in "How was this patch tested?" at #44504.

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member Author

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

@HyukjinKwon
Copy link
Member Author

Merged to master.

@HyukjinKwon HyukjinKwon deleted the SPARK-46530-followup branch January 15, 2024 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants