[SPARK-46530][PYTHON][SQL] Check Python executable when looking up available Data Sources #44519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
force-pushed
the
SPARK-46530
branch
from
f009199 to
42f5fd2
Compare
Member
Author
|
cc @ueshin 🙏 |
Contributor
|
I have reverted #44504 (CommitID: https://github.com/apache/spark/pull/44530/files |
Member
Author
|
Thanks. Let me fix up here. I know the reason. |
HyukjinKwon
force-pushed
the
SPARK-46530
branch
from
42f5fd2 to
2115645
Compare
HyukjinKwon
force-pushed
the
SPARK-46530
branch
from
61e5bb4 to
6f59d34
Compare
Member
Author
|
@LuciferYang @dongjoon-hyun @zhengruifeng if anyone is online can you merge this one please ? I will have to be away from keyboard today.. and this technically fixes the build. |
zhengruifeng
approved these changes
Dec 30, 2023
Contributor
|
merged to master |
Member
Author
|
Thx thx |
Contributor
|
late LGTM, thanks @HyukjinKwon for fixing this |
HyukjinKwon
added a commit
that referenced
this pull request
Jan 4, 2024
…file separator to correctly check PySpark library existence ### What changes were proposed in this pull request? This PR is a followup of #44519 that fixes a mistake of separating the paths. It should use `Files.pathSeparator`. ### Why are the changes needed? It works with testing mode, but it doesn't work with production mode otherwise. ### Does this PR introduce _any_ user-facing change? No, because the main change has not been released. ### How was this patch tested? Manually as described in "How was this patch tested?" at #44504. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44590 from HyukjinKwon/SPARK-46530-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a sort of followup of #44504 but addresses a separate issue. This PR proposes to check:
Why are the changes needed?
For some OSes such as Windows, or minimized Docker containers, there is no Python installed, and it will just fail even when users want to use Scala only. We should check the Python executable, and skip if that does not exist.
Does this PR introduce any user-facing change?
No because the main change has not been released out yet.
How was this patch tested?
Manually tested.
Was this patch authored or co-authored using generative AI tooling?
No.