Skip to content

[SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 #44577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
beliefer wants to merge 1 commit into from
Closed

[SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 #44577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions ...catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/ExpressionImplUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,7 @@
* A utility class for constructing expressions.
*/
public class ExpressionImplUtils {
private static final ThreadLocal<SecureRandom> threadLocalSecureRandom =
ThreadLocal.withInitial(SecureRandom::new);
private static final SecureRandom secureRandom = new SecureRandom();

private static final int GCM_IV_LEN = 12;
private static final int GCM_TAG_LEN = 128;
Expand Down Expand Up @@ -153,7 +152,7 @@ private static SecretKeySpec getSecretKeySpec(byte[] key) {

private static byte[] generateIv(CipherMode mode) {
byte[] iv = new byte[mode.ivLength];
threadLocalSecureRandom.get().nextBytes(iv);
secureRandom.nextBytes(iv);
return iv;
}

Expand Down