[SPARK-46569][SQL] Remove ThreadLocal due to SecureRandom is thread safe since JDK9 #44577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
+CC @srowen, @LuciferYang |
srowen
approved these changes
Jan 4, 2024
LuciferYang
approved these changes
Jan 4, 2024
Contributor
Author
|
The GA failure is unrelated. |
dongjoon-hyun
approved these changes
Jan 4, 2024
Member
|
It seems that the previous merging failed. I merged this to master for Apache Spark 4.0.0. Thank you, @beliefer and all. |
Contributor
Author
|
@dongjoon-hyun Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose to remove
ThreadLocaldue toSecureRandomis thread safe since JDK9.Why are the changes needed?
Spark already upgraded the JDK version to 17.
Before JDK9, we use
ThreadLocalto keep the thread safe forSecureRandom.There are some javadoc of
SecureRandomsince JDK9 show below.Now, we can remove
ThreadLocaldue toSecureRandomis thread safe since JDK9.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.