Skip to content

[SPARK-45991][BUILD] Upgrade protobuf-java to 3.25.1 to match with protobuf 4.25.1#43886

Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-45991
Closed

[SPARK-45991][BUILD] Upgrade protobuf-java to 3.25.1 to match with protobuf 4.25.1#43886
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:SPARK-45991

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Nov 19, 2023

What changes were proposed in this pull request?

This PR aims to upgrade protobuf-java to 3.25.1 in order to match with the corresponding protobuf 4.25.

Why are the changes needed?

protobuf 4.25 is matched with protobuf-java 3.25.

- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>

Note that I also ran

$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Nov 19, 2023
@dongjoon-hyun dongjoon-hyun changed the title [SPARK-45991][BUILD] Upgrade protobuf-java to 3.25.1 to match with protobuf 4.25 [SPARK-45991][BUILD] Upgrade protobuf-java to 3.25.1 to match with protobuf 4.25.1 Nov 19, 2023
@dongjoon-hyun
Copy link
Member Author

Thank you, @HyukjinKwon !

@dongjoon-hyun
Copy link
Member Author

All tests passed. Merged to master for Apache Spark 4.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-45991 branch November 19, 2023 08:52
prabhjyotsingh pushed a commit to acceldata-io/spark3 that referenced this pull request Feb 8, 2025
…atch with `protobuf` 4.25.1

This PR aims to upgrade `protobuf-java` to 3.25.1 in order to match with the corresponding `protobuf` 4.25.

`protobuf 4.25` is matched with `protobuf-java 3.25`.
- protocolbuffers/protobuf#14617

```
- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>
```

Note that I also ran

```
$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean
```

No.

Pass the CIs.

No.

Closes apache#43886 from dongjoon-hyun/SPARK-45991.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit de17724)
prabhjyotsingh pushed a commit to acceldata-io/spark3 that referenced this pull request Feb 8, 2025
…atch with `protobuf` 4.25.1

This PR aims to upgrade `protobuf-java` to 3.25.1 in order to match with the corresponding `protobuf` 4.25.

`protobuf 4.25` is matched with `protobuf-java 3.25`.
- protocolbuffers/protobuf#14617

```
- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>
```

Note that I also ran

```
$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean
```

No.

Pass the CIs.

No.

Closes apache#43886 from dongjoon-hyun/SPARK-45991.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit de17724)
(cherry picked from commit cba5a11)
prabhjyotsingh pushed a commit to acceldata-io/spark3 that referenced this pull request Feb 8, 2025
…atch with `protobuf` 4.25.1

This PR aims to upgrade `protobuf-java` to 3.25.1 in order to match with the corresponding `protobuf` 4.25.

`protobuf 4.25` is matched with `protobuf-java 3.25`.
- protocolbuffers/protobuf#14617

```
- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>
```

Note that I also ran

```
$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean
```

No.

Pass the CIs.

No.

Closes apache#43886 from dongjoon-hyun/SPARK-45991.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit de17724)
(cherry picked from commit cba5a11)
shubhluck pushed a commit to acceldata-io/spark3 that referenced this pull request May 16, 2025
…atch with `protobuf` 4.25.1

This PR aims to upgrade `protobuf-java` to 3.25.1 in order to match with the corresponding `protobuf` 4.25.

`protobuf 4.25` is matched with `protobuf-java 3.25`.
- protocolbuffers/protobuf#14617

```
- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>
```

Note that I also ran

```
$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean
```

No.

Pass the CIs.

No.

Closes apache#43886 from dongjoon-hyun/SPARK-45991.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit de17724)
(cherry picked from commit cba5a11)
senthh pushed a commit to acceldata-io/spark3 that referenced this pull request May 26, 2025
…atch with `protobuf` 4.25.1

This PR aims to upgrade `protobuf-java` to 3.25.1 in order to match with the corresponding `protobuf` 4.25.

`protobuf 4.25` is matched with `protobuf-java 3.25`.
- protocolbuffers/protobuf#14617

```
- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>
```

Note that I also ran

```
$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean
```

No.

Pass the CIs.

No.

Closes apache#43886 from dongjoon-hyun/SPARK-45991.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit de17724)
(cherry picked from commit cba5a11)
shubhluck pushed a commit to acceldata-io/spark3 that referenced this pull request Sep 3, 2025
…atch with `protobuf` 4.25.1

This PR aims to upgrade `protobuf-java` to 3.25.1 in order to match with the corresponding `protobuf` 4.25.

`protobuf 4.25` is matched with `protobuf-java 3.25`.
- protocolbuffers/protobuf#14617

```
- set(protobuf_VERSION_STRING "4.24.0")
+ set(protobuf_VERSION_STRING "4.25.0")
- <version>3.24.0</version>
+ <version>3.25.0</version>
```

Note that I also ran

```
$ dev/connect-gen-protos.sh

$ git status
On branch SPARK-45991
Your branch is up to date with 'dongjoon/SPARK-45991'.

nothing to commit, working tree clean
```

No.

Pass the CIs.

No.

Closes apache#43886 from dongjoon-hyun/SPARK-45991.

Authored-by: Dongjoon Hyun <dhyun@apple.com>
Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
(cherry picked from commit de17724)
(cherry picked from commit cba5a11)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments